Skip to content

[WEB-2419] chore: add toast alerts post access change of a page #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Sep 12, 2024
Merged

[WEB-2419] chore: add toast alerts post access change of a page #5569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion web/core/components/pages/dropdowns/quick-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,26 @@ export const PageQuickActions: React.FC<Props> = observer((props) => {
const MENU_ITEMS: TContextMenuItem[] = [
{
key: "make-public-private",
action: access === 0 ? makePrivate : makePublic,
action: async () => {
const changedPageType = access === 0 ? "private" : "public";

try {
if (access === 0) await makePrivate();
else await makePublic();

setToast({
type: TOAST_TYPE.SUCCESS,
title: "Success!",
message: `The page has been marked ${changedPageType} and moved to the ${changedPageType} section.`,
});
} catch (err) {
setToast({
type: TOAST_TYPE.ERROR,
title: "Error!",
message: `The page couldn't be marked ${changedPageType}. Please try again.`,
});
}
},
Comment on lines +51 to +70
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve changes with suggestions for enhanced error handling.

The asynchronous function within the action property of MENU_ITEMS is well-implemented, providing clear user feedback through toast notifications. The use of a try-catch block for error handling is a good practice.

However, consider enhancing the error handling by logging the error or providing more detailed feedback to the user. This could help in diagnosing issues more effectively in production.

+ import { logError } from "@/helpers/error.helper";

  try {
    if (access === 0) await makePrivate();
    else await makePublic();
    setToast({
      type: TOAST_TYPE.SUCCESS,
      title: "Success!",
      message: `The page has been marked ${changedPageType} and moved to the ${changedPageType} section.`,
    });
  } catch (err) {
    logError(err); // Log the error for better diagnostics
    setToast({
      type: TOAST_TYPE.ERROR,
      title: "Error!",
      message: `The page couldn't be marked ${changedPageType}. Please try again. Error: ${err.message}`,
    });
  }

Committable suggestion was skipped due to low confidence.

title: access === 0 ? "Make private" : "Make public",
icon: access === 0 ? Lock : UsersRound,
shouldRender: canCurrentUserChangeAccess && !archived_at,
Expand Down