Skip to content

[WEB-2393] chore: removal of .svg from supported image formats #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 2 commits into from
Sep 12, 2024
Merged

[WEB-2393] chore: removal of .svg from supported image formats #5582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2640a
Updated supported image formats
Jimmycutie Sep 11, 2024
a52c0a3
Updated image accepting functions
Jimmycutie Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions web/core/components/core/image-picker-popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
const { getRootProps, getInputProps, isDragActive, fileRejections } = useDropzone({
onDrop,
accept: {
"image/*": [".png", ".jpg", ".jpeg", ".svg", ".webp"],
"image/*": [".png", ".jpg", ".jpeg", ".webp"],
},
maxSize: config?.file_size_limit ?? MAX_FILE_SIZE,
});
Expand Down Expand Up @@ -355,9 +355,7 @@ export const ImagePickerPopover: React.FC<Props> = observer((props) => {
</p>
)}

<p className="text-sm text-custom-text-200">
File formats supported- .jpeg, .jpg, .png, .webp, .svg
</p>
<p className="text-sm text-custom-text-200">File formats supported- .jpeg, .jpg, .png, .webp</p>

<div className="flex h-12 items-start justify-end gap-2">
<Button
Expand Down
6 changes: 2 additions & 4 deletions web/core/components/core/modals/user-image-upload-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const UserImageUploadModal: React.FC<Props> = observer((props) => {
const { getRootProps, getInputProps, isDragActive, fileRejections } = useDropzone({
onDrop,
accept: {
"image/*": [".png", ".jpg", ".jpeg", ".svg", ".webp"],
"image/*": [".png", ".jpg", ".jpeg", ".webp"],
},
maxSize: config?.file_size_limit ?? MAX_FILE_SIZE,
multiple: false,
Expand Down Expand Up @@ -156,9 +156,7 @@ export const UserImageUploadModal: React.FC<Props> = observer((props) => {
)}
</div>
</div>
<p className="my-4 text-sm text-custom-text-200">
File formats supported- .jpeg, .jpg, .png, .webp, .svg
</p>
<p className="my-4 text-sm text-custom-text-200">File formats supported- .jpeg, .jpg, .png, .webp</p>
<div className="flex items-center justify-between">
{handleDelete && (
<Button variant="danger" size="sm" onClick={handleDelete} disabled={!value}>
Expand Down
8 changes: 3 additions & 5 deletions web/core/components/core/modals/workspace-image-upload-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const WorkspaceImageUploadModal: React.FC<Props> = observer((props) => {
const { getRootProps, getInputProps, isDragActive, fileRejections } = useDropzone({
onDrop,
accept: {
"image/*": [".png", ".jpg", ".jpeg", ".svg", ".webp"],
"image/*": [".png", ".jpg", ".jpeg", ".webp"],
},
maxSize: config?.file_size_limit ?? MAX_FILE_SIZE,
multiple: false,
Expand Down Expand Up @@ -150,7 +150,7 @@ export const WorkspaceImageUploadModal: React.FC<Props> = observer((props) => {
</div>
)}

<input {...getInputProps()}/>
<input {...getInputProps()} />
</div>
</div>
{fileRejections.length > 0 && (
Expand All @@ -162,9 +162,7 @@ export const WorkspaceImageUploadModal: React.FC<Props> = observer((props) => {
)}
</div>
</div>
<p className="my-4 text-sm text-custom-text-200">
File formats supported- .jpeg, .jpg, .png, .webp, .svg
</p>
<p className="my-4 text-sm text-custom-text-200">File formats supported- .jpeg, .jpg, .png, .webp</p>
<div className="flex items-center justify-between">
{handleRemove && (
<Button variant="danger" size="sm" onClick={handleRemove} disabled={!value}>
Expand Down