[WEB-2453] fix: Render on hover only when enabled#5609
[WEB-2453] fix: Render on hover only when enabled#5609SatishGandham merged 4 commits intopreviewfrom
Conversation
WalkthroughThe changes introduce a new optional property, Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
SatishGandham
left a comment
SatishGandham
left a comment
There was a problem hiding this comment.
What are the cases where we need to render it by default?
@SatishGandham for now the ones that are rendering on hover are the ones in issue layouts. everywhere it is rendering by default. All the cases needs to tested individually and fix indentation issues before enabling it in them |
… of interference with keyboard navigation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| closeDelay, | ||
| isMobile = false, | ||
| renderByDefault = true, | ||
| renderByDefault = true, //FIXME: tooltip should always render on hover and not by default, this is a temporary fix |
There was a problem hiding this comment.
Update the renderByDefault prop value to align with the intended behavior.
The updated comment suggests that the tooltip should always render on hover, not by default. However, the renderByDefault prop is still set to true, which contradicts the comment.
To avoid confusion and ensure consistency between the code and the comment, consider updating the prop value to match the intended behavior:
- renderByDefault = true, //FIXME: tooltip should always render on hover and not by default, this is a temporary fix
+ renderByDefault = false, // Tooltip should always render on hover and not by defaultAlternatively, if the current behavior is indeed a temporary fix, provide a clear timeline or reference to the planned changes to address this discrepancy.
If you need any assistance in implementing the intended behavior or have any questions, feel free to reach out. I'm happy to help!
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| renderByDefault = true, //FIXME: tooltip should always render on hover and not by default, this is a temporary fix | |
| renderByDefault = false, // Tooltip should always render on hover and not by default |
2 participants
This PR changes the code to enable render on Hover for both dropdown and tooltip only when enabled and treats
renderByDefaultas the single source of truth for issue property dropdownsSummary by CodeRabbit
Release Notes
New Features
renderToolTipByDefault, across various dropdown components to enhance tooltip rendering flexibility.renderByDefaultprop to several spreadsheet column components, allowing for controlled rendering based on user context.Bug Fixes