Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const ArchivedIssueDetailsPage = observer(() => {

const { getProjectById } = useProject();

const { isLoading, data: swrArchivedIssueDetails } = useSWR(
const { isLoading } = useSWR(
workspaceSlug && projectId && archivedIssueId
? `ARCHIVED_ISSUE_DETAIL_${workspaceSlug}_${projectId}_${archivedIssueId}`
: null,
Expand Down Expand Up @@ -65,7 +65,6 @@ const ArchivedIssueDetailsPage = observer(() => {
<div className="h-full w-full space-y-3 divide-y-2 divide-custom-border-200 overflow-y-auto">
{workspaceSlug && projectId && archivedIssueId && (
<IssueDetailRoot
swrIssueDetails={swrArchivedIssueDetails}
workspaceSlug={workspaceSlug.toString()}
projectId={projectId.toString()}
issueId={archivedIssueId.toString()}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ const IssueDetailsPage = observer(() => {
const { getProjectById } = useProject();
const { toggleIssueDetailSidebar, issueDetailSidebarCollapsed } = useAppTheme();
// fetching issue details
const {
isLoading,
data: swrIssueDetails,
error,
} = useSWR(
const { isLoading, error } = useSWR(
workspaceSlug && projectId && issueId ? `ISSUE_DETAIL_${workspaceSlug}_${projectId}_${issueId}` : null,
workspaceSlug && projectId && issueId
? () => fetchIssue(workspaceSlug.toString(), projectId.toString(), issueId.toString())
Expand Down Expand Up @@ -95,7 +91,6 @@ const IssueDetailsPage = observer(() => {
projectId &&
issueId && (
<IssueDetailRoot
swrIssueDetails={swrIssueDetails}
workspaceSlug={workspaceSlug.toString()}
projectId={projectId.toString()}
issueId={issueId.toString()}
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/issues/description-input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export type IssueDescriptionInputProps = {
issueOperations: TIssueOperations;
placeholder?: string | ((isFocused: boolean, value: string) => string);
setIsSubmitting: (initialValue: "submitting" | "submitted" | "saved") => void;
swrIssueDescription: string | null | undefined;
swrIssueDescription?: string | null | undefined;
};

export const IssueDescriptionInput: FC<IssueDescriptionInputProps> = observer((props) => {
Expand Down
4 changes: 1 addition & 3 deletions web/core/components/issues/issue-detail/main-content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,10 @@ type Props = {
issueOperations: TIssueOperations;
isEditable: boolean;
isArchived: boolean;
swrIssueDetails: TIssue | null | undefined;
};

export const IssueMainContent: React.FC<Props> = observer((props) => {
const { workspaceSlug, projectId, issueId, issueOperations, isEditable, isArchived, swrIssueDetails } = props;
const { workspaceSlug, projectId, issueId, issueOperations, isEditable, isArchived } = props;
// states
const [isSubmitting, setIsSubmitting] = useState<"submitting" | "submitted" | "saved">("saved");
// hooks
Expand Down Expand Up @@ -88,7 +87,6 @@ export const IssueMainContent: React.FC<Props> = observer((props) => {

{/* {issue?.description_html === issueDescription && ( */}
<IssueDescriptionInput
swrIssueDescription={swrIssueDetails?.description_html}
workspaceSlug={workspaceSlug}
projectId={issue.project_id}
issueId={issue.id}
Expand Down
4 changes: 1 addition & 3 deletions web/core/components/issues/issue-detail/root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,10 @@ export type TIssueDetailRoot = {
projectId: string;
issueId: string;
is_archived?: boolean;
swrIssueDetails: TIssue | null | undefined;
};

export const IssueDetailRoot: FC<TIssueDetailRoot> = observer((props) => {
const { workspaceSlug, projectId, issueId, swrIssueDetails, is_archived = false } = props;
const { workspaceSlug, projectId, issueId, is_archived = false } = props;
// router
const router = useAppRouter();
const pathname = usePathname();
Expand Down Expand Up @@ -349,7 +348,6 @@ export const IssueDetailRoot: FC<TIssueDetailRoot> = observer((props) => {
<div className="max-w-2/3 h-full w-full space-y-8 overflow-y-auto px-9 py-5">
<IssueMainContent
workspaceSlug={workspaceSlug}
swrIssueDetails={swrIssueDetails}
projectId={projectId}
issueId={issueId}
issueOperations={issueOperations}
Expand Down
2 changes: 0 additions & 2 deletions web/core/components/issues/peek-overview/issue-detail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ export const PeekOverviewIssueDetails: FC<IPeekOverviewIssueDetails> = observer(
projectId={issue.project_id}
issueId={issue.id}
initialValue={issueDescription}
// for now peek overview doesn't have live syncing while tab changes
swrIssueDescription={issueDescription}
disabled={disabled}
issueOperations={issueOperations}
setIsSubmitting={(value) => setIsSubmitting(value)}
Expand Down