[WEB-2511] fix: fix overlapping issues for headers globally

[sharma01ketan]

[WEB-2511]

This PR fixes the problem of headers having inconsistent z-indices by changing making changes in Header file in Packages.

New Z-indices: (Headers did not have background colour which was causing overlapping isues)
EHeaderVariant.PRIMARY : bg-custom-background-100 z-[18]
EHeaderVariant.SECONDARY: bg-custom-background-100 z-[15]
EHeaderVariant.TERNARY: bg-custom-background-100 z-[12] (This change was introduced in a previous PR)

Global Changes

• The Primary Header now has a z-[18], which requires two changes, one in AppHeader(being used globally) and EHeaderVariant.PRIMARY. Similarly Secondary Header now has a z-index of 15.

Otherchanges

• Changes made to fix the issue intake and inbox headers (desktop and mobile both have z-[11] now and mobile was had to borders applied to it, which is now fixed)

Desktop

Mobile

• Changes made to fix the draft headers (desktop and mobile)
  Previous State

Current State

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced visual presentation of headers and buttons with updated background colors and z-index adjustments.

• Bug Fixes

  • Improved spacing for mobile header buttons for better usability.
  • Adjusted styles for various header components to improve overall layout and stacking order.

These changes contribute to a more polished and user-friendly interface across various components of the application.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes across multiple components primarily involve modifications to CSS class strings, specifically focusing on the addition of background color classes and adjustments to z-index values. These updates enhance the visual presentation and stacking order of various header and button elements without altering their underlying functionality.

Changes

File Path	Change Summary
packages/ui/src/header/helper.tsx	Updated headerStyle for PRIMARY and SECONDARY variants to include bg-custom-background-100 and adjusted z-index values.
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/draft-issues/page.tsx	Modified ProjectDraftIssuesPage to add bg-custom-background-100 and z-index to the button's containing div.
web/core/components/core/app-header.tsx	Increased z-index from 15 to 18 for the outer <div> of AppHeader.
web/core/components/inbox/content/inbox-issue-header.tsx	Updated Row component class to include bg-custom-background-100 z-[15].
web/core/components/inbox/content/inbox-issue-mobile-header.tsx	Added margin-right class to MoveRight button and updated flex item container with background color and z-index.
web/core/components/inbox/content/root.tsx	Altered class name of a div to specify a minimum height of 52px and added z-index of 11.

Possibly related PRs

• [WEB-2475] fix: applied filters header z-index and transparency  #5632: The changes in the main PR regarding the headerStyle object and z-index adjustments are related to the modifications made in the GlobalViewsHeader component, which also involves setting a z-index and background color for improved visual layering.
• [WEB-2417] fix: header theme #5564: The changes in the AppHeader component's z-index align with the main PR's focus on z-index adjustments in the headerStyle object, indicating a direct relationship in styling enhancements.
• [WEB-2482] fix: list layout quick action styling #5639: The adjustments to the Row element's class names in the ListGroup component, which include z-index modifications, relate to the main PR's changes in header styling and z-index management.
• [WEB-2316] fix: Style Calculation performance issue in virtualization #5647: The performance optimizations in the RenderIfVisible component, which may involve z-index and rendering behavior, connect to the main PR's focus on header styling and z-index adjustments.

Suggested labels

🐛bug, 🌟improvement

Suggested reviewers

• sriramveeraghanta
• SatishGandham
• anmolsinghbhatia

Poem

🐰 In the header, colors bright,
Z-index dancing, what a sight!
Backgrounds change, the buttons gleam,
A visual treat, a coder's dream!
With each tweak, our app's a delight,
Hopping forward, ready for flight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sharma01ketan]

Mobile Header had improper spacing for icon.