[WEB-2504] chore: issue relation hard delete

[NarayanBavisetti]

chore:

• perform a hard delete on the issue relation.
• handled the multiple inboxes returned in the get_or_create.

Issue Link: WEB-2504

Summary by CodeRabbit

• New Features

  • Enhanced logic for managing Inbox objects associated with projects, ensuring that new Inbox instances are only created when no existing default Inbox is found.

• Bug Fixes

  • Updated deletion behavior for issue_relation objects, shifting from a soft delete to a hard delete for improved data management.

[coderabbitai]

Walkthrough

The changes in this pull request primarily modify the handling of Inbox objects within the project management functionality. The patch method in the ProjectView class now filters for existing Inbox instances before creating new ones, ensuring that duplicates are avoided. Additionally, the deletion behavior of issue_relation objects has been updated to a hard delete, and the partial_update method in the project base file has been adjusted to improve the creation logic for Inbox objects.

Changes

File Path	Change Summary
apiserver/plane/api/views/project.py	Modified patch method to filter for existing Inbox objects before creating new ones.
apiserver/plane/app/views/issue/relation.py	Updated remove_relation method to use delete(soft=False) for hard deletion of issue_relation objects.
apiserver/plane/app/views/project/base.py	Altered partial_update method to check for existing default Inbox before creating a new one.

Possibly related PRs

• [WEB-2476] fix: removed creation of multiple intakes #5628: This PR modifies the logic for creating Inbox objects in the project.py file, which is directly related to the changes made in the patch method of the ProjectView class in the main PR.
• chore: render the first intake from the list #5650: This PR primarily deals with retrieving the first Inbox from a list, related to the overall handling of Inbox objects, a central theme in the main PR's changes.

🐇 In the land of code where rabbits play,
New Inbox logic hops in today!
No more duplicates, swift and neat,
With every patch, our tasks complete.
Soft deletes are gone, hard ones in sight,
Hooray for changes, everything feels right! 🥕

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66cfc73 and dcf6da6.

Files selected for processing (3)

• apiserver/plane/api/views/project.py (1 hunks)
• apiserver/plane/app/views/issue/relation.py (1 hunks)
• apiserver/plane/app/views/project/base.py (1 hunks)

Additional comments not posted (3)

apiserver/plane/app/views/issue/relation.py (1)

270-270: Verify the alignment of the hard delete operation with the business requirements and data retention policies.

The code change to perform a hard delete on the issue_relation object is syntactically correct and logically sound. However, please ensure that this change aligns with the business requirements and data retention policies, as a hard delete permanently removes the associated data from the database, which could have implications on data recovery and auditing capabilities.

apiserver/plane/api/views/project.py (1)

304-313: LGTM! The updated logic improves the handling of Inbox objects.

The changes in this code segment enhance the logic for managing Inbox objects associated with a project. By first filtering for an existing default Inbox before creating a new one, the code ensures that duplicate default Inbox instances are avoided. This approach improves the overall handling and consistency of Inbox objects within the project management functionality.

apiserver/plane/app/views/project/base.py (1)

441-450: LGTM!

The updated inbox creation logic looks good. It now checks for an existing default inbox before creating a new one, preventing duplicates.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.