[WEB-2520] fix-Sorted Icon Not Updating Dynamically in Spreadsheet View

[Jimmycutie]

Problem Statement

Sort icon along the headers in spreadsheet view wasn't getting updated when sorting order was changed.

Solution

Added conditional rendering for the icon to get updated whenever the sorting order gets changed.

Screenshots and Media

Before

After

References

[WEB-2520]

Summary by CodeRabbit

• New Features

  • Improved visual feedback for sorting direction in the issue spreadsheet, enhancing user experience when filtering data.

• Bug Fixes

  • Resolved inconsistencies in the display of sorting indicators based on active filters.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the HeaderColumn component's rendering logic for sorting indicators. The implementation now includes conditional rendering based on the comparison between propertyDetails.ascendingOrderKey and displayFilters.order_by, allowing for dynamic display of sorting icons.

Changes

File	Change Summary
web/core/components/issues/issue-layouts/spreadsheet/columns/header-column.tsx	Modified rendering logic for sorting indicators to use conditional rendering based on filter state.

Possibly related PRs

• [WEB-2466] fix-Date Sorting Dropdown Not Mutating Between Ascending and Descending #5670: The changes in this PR involve conditional rendering of sorting icons (ArrowUpWideNarrow and ArrowDownWideNarrow), which is directly related to the modifications made in the HeaderColumn component of the main PR that also focuses on rendering logic for sorting indicators.

Suggested reviewers

• sriramveeraghanta
• SatishGandham

🐰 In the columns where data flows,
Sorting arrows dance in rows.
Up and down, they twist and twirl,
Guiding users in a whirl.
With a click, the order's clear,
Hopping joyfully, we cheer! 🎉

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 20f8242 and bd489b2.

Files selected for processing (1)

• web/core/components/issues/issue-layouts/spreadsheet/columns/header-column.tsx (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• web/core/components/issues/issue-layouts/spreadsheet/columns/header-column.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.