[WEB-2551] fix: list layout item

[anmolsinghbhatia]

Problem:

1. The issue properties dropdown in the issue list layout is not rendering dynamically based on the available space.
2. Duplicate code for the issue name.
3. Missing validation for the draft issue control link.

Solution:

1. The issue was caused by an unnecessary "truncate" classname in the control link element, which has been removed to ensure the dropdown renders as intended.
2. Refactored the JSX for the issue name to eliminate duplication.
3. Added the required validation for the draft issue control link.

Reference:

[WEB-2551]

Media:

Before	After

Summary by CodeRabbit

• New Features

  • Improved rendering logic for issue links to enhance user experience.
  • Consolidated tooltip display for better consistency across issue statuses.

• Bug Fixes

  • Prevented interaction with draft issues by updating the disabled condition.

[coderabbitai]

Walkthrough

The changes in the IssueBlock component focus on refining the rendering logic and interaction conditions. The className for the main issue link has been simplified, and the conditions for disabling interactions have been broadened to include draft issues. The tooltip rendering has been consolidated into a single component, enhancing consistency in displaying the issue name.

Changes

File Path	Change Summary
web/core/components/issues/issue-layouts/list/block.tsx	Modified rendering logic, simplified className, expanded disabled condition, and refactored tooltip rendering.

Possibly related PRs

• [WEB-2390] fix: Clickable Area for Issue List Layout Item #5536: Enhancements to the clickable area and interaction model for issue list layout items.
• [WEB-2316] fix: Style Calculation performance issue in virtualization #5647: Improvements to rendering logic and user experience in the RenderIfVisible and IssueBlockRoot components.

Suggested labels

🌟enhancement

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Poem

In the garden of code, where issues bloom,
A rabbit hops by, dispelling the gloom.
With links that are clear and tooltips that shine,
Interaction is smooth, oh how divine!
Drafts now take pause, as changes take flight,
In the realm of the code, everything's right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/issues/issue-layouts/list/block.tsx (1)

234-242: Improved issue name rendering with tooltip

Great job refactoring the issue name rendering:

1. The Tooltip component enhances user experience by showing the full name on hover.
2. Disabling the tooltip during drag operations (disabled={isCurrentBlockDragging}) is a nice touch.

Consider adding an aria-label to the <p> tag for improved accessibility:

- <p className="w-full truncate cursor-pointer text-sm text-custom-text-100">{issue.name}</p>
+ <p className="w-full truncate cursor-pointer text-sm text-custom-text-100" aria-label={`Issue: ${issue.name}`}>{issue.name}</p>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6e0ece4 and 5bbdaa3.

📒 Files selected for processing (1)

• web/core/components/issues/issue-layouts/list/block.tsx (2 hunks)

🔇 Additional comments (2)

web/core/components/issues/issue-layouts/list/block.tsx (2)

140-141: Improved rendering and interaction handling

These changes align well with the PR objectives:

1. Removing the truncate class allows for better dynamic rendering based on available space.
2. Adding issue?.is_draft to the disabled prop prevents interaction with draft issues, enhancing the component's functionality.

---

Line range hint 1-300: Summary: PR objectives successfully addressed

The changes in this file effectively address the main points mentioned in the PR objectives:

1. The dropdown rendering issue is resolved by removing the unnecessary "truncate" class.
2. The JSX for the issue name has been refactored, eliminating code duplication.
3. Validation for the draft issue control link has been added by including issue?.is_draft in the disabled prop.

These improvements enhance the component's functionality and align well with the stated goals of the pull request.