Skip to content

chore: properties validation. #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 1 commit into from
Sep 27, 2024
Merged

chore: properties validation. #5718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/ce/components/issue-types/values/update.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
type TIssueAdditionalPropertyValuesUpdateProps = {
export type TIssueAdditionalPropertyValuesUpdateProps = {
issueId: string;
issueTypeId: string;
projectId: string;
workspaceSlug: string;
isDisabled: boolean;
};

export const IssueAdditionalPropertyValuesUpdate: React.FC<TIssueAdditionalPropertyValuesUpdateProps> = () => <></>;
1 change: 1 addition & 0 deletions web/core/components/issues/issue-detail/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ export const IssueDetailsSidebar: React.FC<Props> = observer((props) => {
issueTypeId={issue.type_id}
projectId={projectId}
workspaceSlug={workspaceSlug}
isDisabled={!isEditable}
/>
)}
</div>
Expand Down
1 change: 1 addition & 0 deletions web/core/components/issues/peek-overview/properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ export const PeekOverviewProperties: FC<IPeekOverviewProperties> = observer((pro
issueTypeId={issue.type_id}
projectId={projectId}
workspaceSlug={workspaceSlug}
isDisabled={disabled}
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

isDisabled Prop Not Utilized in IssueAdditionalPropertyValuesUpdate Component

The isDisabled prop is defined in the IssueAdditionalPropertyValuesUpdate component but is not actively used within its implementation. This oversight may lead to inconsistencies in handling the disabled state across the application.

  • Action Required: Update the IssueAdditionalPropertyValuesUpdate component to utilize the isDisabled prop effectively, ensuring it controls the component's disabled state as intended.
🔗 Analysis chain

Verify the implementation of isDisabled in the IssueAdditionalPropertyValuesUpdate component.

The addition of the isDisabled prop improves the component's flexibility and consistency with other child components. This change appears to be part of a larger effort to implement consistent property validation across components.

To ensure the change is fully implemented, please verify that the IssueAdditionalPropertyValuesUpdate component correctly handles the isDisabled prop. You can use the following script to check its implementation:

This script will help you locate the component definition and verify that the isDisabled prop is correctly implemented and used within the component.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the implementation of isDisabled prop in IssueAdditionalPropertyValuesUpdate

# Search for the IssueAdditionalPropertyValuesUpdate component definition
echo "Searching for IssueAdditionalPropertyValuesUpdate component definition:"
rg --type typescript "export const IssueAdditionalPropertyValuesUpdate" -A 10

# Search for usage of isDisabled prop within the component
echo "\nSearching for usage of isDisabled prop within the component:"
rg --type typescript "const IssueAdditionalPropertyValuesUpdate.*isDisabled.*=.*props" -A 20

Length of output: 532

Script:

#!/bin/bash
# Description: Check the implementation of isDisabled prop in IssueAdditionalPropertyValuesUpdate

# Search for the IssueAdditionalPropertyValuesUpdate component definition
echo "Searching for IssueAdditionalPropertyValuesUpdate component definition:"
rg --glob "*.tsx" "export const IssueAdditionalPropertyValuesUpdate" -A 10

# Search for usage of isDisabled prop within the component
echo "\nSearching for usage of isDisabled prop within the component:"
rg --glob "*.tsx" "const IssueAdditionalPropertyValuesUpdate.*isDisabled.*=.*props" -A 20

Length of output: 621

Script:

#!/bin/bash
# Description: Thoroughly search for 'isDisabled' usage within the IssueAdditionalPropertyValuesUpdate component and across the codebase

# Define the component file path based on previous output
COMPONENT_PATH="web/ce/components/issue-types/values/update.tsx"

# Verify if the component file exists
if [ -f "$COMPONENT_PATH" ]; then
  echo "Searching for 'isDisabled' usage within $COMPONENT_PATH:"
  rg "isDisabled" "$COMPONENT_PATH"
else
  echo "Component file $COMPONENT_PATH not found."
fi

# Search for all occurrences of 'isDisabled' in TypeScript and TSX files across the codebase
echo -e "\nSearching for all usages of 'isDisabled' in TypeScript and TSX files:"
rg --glob "*.ts*" "isDisabled"

Length of output: 3733

/>
)}
</div>
Expand Down