-
Notifications
You must be signed in to change notification settings - Fork 3.6k
WEB-2381 Chore: intake refactor #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9a5d06b
chore: intake emails and forms
gakshita 3a75b8f
Merge branch 'preview' of https://github.com/makeplane/plane into cho…
gakshita 252698e
fix: moved files to ee
gakshita 44e7b70
fix: intake form ui
gakshita e3908a3
Merge branch 'preview' of https://github.com/makeplane/plane into cho…
gakshita 6ce5ab0
fix: settings apis integrated
gakshita 0d398f4
fix: removed publish api
gakshita dea383a
fix: removed space app
gakshita 583d483
fix: lint issue
gakshita bfa0eb9
fix: removed logs
gakshita 24d96df
fix: removed comment
gakshita 7e7cc36
fix: improved success image
gakshita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "./header"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "ce/components/projects/settings/intake"; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Incorrect import path for
ProjectInboxHeadercomponent.The
ProjectInboxHeadercomponent is located atweb/ce/components/projects/settings/intake/header.tsx, but the import statement inlayout.tsxuses the path@/plane-web/components/projects/settings/intake. Unless there is anindex.tsfile in theintakedirectory that re-exportsProjectInboxHeader, this import path is incorrect.Recommendations:
@/ce/components/projects/settings/intake/headerto accurately reflect the component's location.index.tsfile in theintakedirectory that re-exportsProjectInboxHeader, allowing the current import path to remain valid.🔗 Analysis chain
Approve the change to absolute import, but clarification needed.
The switch from a relative import to an absolute import is a good practice that can improve code maintainability. However, I have a couple of questions:
The new import path includes "settings" (
@/plane-web/components/projects/settings/intake). Is this the correct location for a component used in the inbox layout? It seems counterintuitive to have an inbox-related component in a settings folder.How does this change relate to the PR objective of "enabling issues to be added to the intake system through emails and forms"? The current modification doesn't seem to directly address this feature.
To ensure the component is in the correct location, please run the following command:
This will help us confirm that the import path is correct and the component is appropriately placed in the project structure.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 36
Script:
Length of output: 121
Script:
Length of output: 202