Skip to content

[WEB-2488] fix: only the owner of a view can publish their project views #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharma01ketan wants to merge 3 commits into from
Closed

[WEB-2488] fix: only the owner of a view can publish their project views #5799

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50fa85b
change the rendering logic
sharma01ketan Oct 11, 2024
0780bda
fix
sharma01ketan Oct 21, 2024
2b96b5b
clean code
sharma01ketan Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions web/core/components/views/quick-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,13 @@ export const ViewQuickActions: React.FC<Props> = observer((props) => {
const { allowPermissions } = useUserPermissions();
// auth
const isOwner = view?.owned_by === data?.id;
const canPublishView = allowPermissions(
[EUserPermissions.ADMIN, EUserPermissions.MEMBER],
EUserPermissionsLevel.PROJECT
);
const isAdmin = allowPermissions([EUserPermissions.ADMIN], EUserPermissionsLevel.PROJECT, workspaceSlug, projectId);

const { isPublishModalOpen, setPublishModalOpen, publishContextMenu } = useViewPublish(
!!view.anchor,
isAdmin || isOwner
);
const { isPublishModalOpen, setPublishModalOpen, publishContextMenu } = useViewPublish(!!view.anchor, isOwner);

const viewLink = `${workspaceSlug}/projects/${projectId}/views/${view.id}`;
const handleCopyText = () =>
Expand Down Expand Up @@ -98,6 +99,7 @@ export const ViewQuickActions: React.FC<Props> = observer((props) => {
<CustomMenu ellipsis placement="bottom-end" closeOnSelect>
{MENU_ITEMS.map((item) => {
if (item.shouldRender === false) return null;
if (item.key === "publish" && !canPublishView) return null;
return (
<CustomMenu.MenuItem
key={item.key}
Expand Down