Skip to content

[WEB-2598] fix: show toast when existing issue is added to cycles #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Oct 17, 2024
Merged

[WEB-2598] fix: show toast when existing issue is added to cycles #5807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions web/core/components/issues/issue-layouts/calendar/quick-add-issue-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { PlusIcon } from "lucide-react";
// types
import { ISearchIssueResponse, TIssue } from "@plane/types";
// ui
import { TOAST_TYPE, setToast, CustomMenu } from "@plane/ui";
import { CustomMenu, setPromiseToast } from "@plane/ui";
// components
import { ExistingIssuesListModal } from "@/components/core";
import { QuickAddIssueRoot } from "@/components/issues";
Expand Down Expand Up @@ -45,22 +45,21 @@ export const CalendarQuickAddIssueActions: FC<TCalendarQuickAddIssueActions> = o
if (!workspaceSlug || !projectId) return;

const issueIds = data.map((i) => i.id);
const addExistingIssuesPromise = Promise.all(
data.map((issue) => updateIssue(workspaceSlug.toString(), projectId.toString(), issue.id, prePopulatedData ?? {}))
).then(() => addIssuesToView?.(issueIds));

try {
// To handle all updates in parallel
await Promise.all(
data.map((issue) =>
updateIssue(workspaceSlug.toString(), projectId.toString(), issue.id, prePopulatedData ?? {})
)
);
await addIssuesToView?.(issueIds);
} catch (error) {
setToast({
type: TOAST_TYPE.ERROR,
setPromiseToast(addExistingIssuesPromise, {
loading: `Adding ${issueIds.length > 1 ? "issues" : "issue"} to cycle...`,
success: {
title: "Success!",
message: () => `${issueIds.length > 1 ? "Issues" : "Issue"} added to cycle successfully.`,
},
error: {
title: "Error!",
message: "Something went wrong. Please try again.",
});
}
message: (err) => err?.message || "Something went wrong. Please try again.",
},
});
};

const handleNewIssue = () => {
Expand Down Expand Up @@ -130,4 +129,4 @@ export const CalendarQuickAddIssueActions: FC<TCalendarQuickAddIssueActions> = o
/>
</>
);
});
});