Skip to content

[WEB-2695] chore: urgent priority icon improvement #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Oct 22, 2024
Merged

[WEB-2695] chore: urgent priority icon improvement #5879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/ui/src/icons/priority-icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const PriorityIcon: React.FC<IPriorityIcon> = (props) => {
const { priority, className = "", containerClassName = "", size = 14, withContainer = false } = props;

const priorityClasses = {
urgent: "bg-red-600 text-red-500 border-red-600",
urgent: "bg-red-600/20 text-red-600 border-red-600",
high: "bg-orange-500/20 text-orange-500 border-orange-500",
medium: "bg-yellow-500/20 text-yellow-500 border-yellow-500",
low: "bg-custom-primary-100/20 text-custom-primary-100 border-custom-primary-100",
Expand Down Expand Up @@ -49,8 +49,6 @@ export const PriorityIcon: React.FC<IPriorityIcon> = (props) => {
size={size}
className={cn(
{
"text-white": priority === "urgent",
// centre align the icons
"translate-x-[0.0625rem]": priority === "high",
"translate-x-0.5": priority === "medium",
"translate-x-1": priority === "low",
Expand Down
22 changes: 11 additions & 11 deletions web/core/components/dropdowns/priority.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const BorderButton = (props: ButtonProps) => {
const priorityDetails = ISSUE_PRIORITIES.find((p) => p.key === priority);

const priorityClasses = {
urgent: "bg-red-500/20 text-red-950 border-red-500",
urgent: "bg-red-600/10 text-red-600 border-red-600 px-1",
high: "bg-orange-500/20 text-orange-950 border-orange-500",
medium: "bg-yellow-500/20 text-yellow-950 border-yellow-500",
low: "bg-custom-primary-100/20 text-custom-primary-950 border-custom-primary-100",
Expand All @@ -88,7 +88,7 @@ const BorderButton = (props: ButtonProps) => {
// compact the icons if text is hidden
"px-0.5": hideText,
// highlight the whole button if text is hidden and priority is urgent
"bg-red-600 border-red-600": priority === "urgent" && hideText && highlightUrgent,
"bg-red-600/10 border-red-600": priority === "urgent" && hideText && highlightUrgent,
},
className
)}
Expand All @@ -98,7 +98,8 @@ const BorderButton = (props: ButtonProps) => {
<div
className={cn({
// highlight just the icon if text is visible and priority is urgent
"bg-red-600 p-1 rounded": priority === "urgent" && !hideText && highlightUrgent,
"bg-red-600/20 p-0.5 rounded border border-red-600":
priority === "urgent" && !hideText && highlightUrgent,
})}
>
<PriorityIcon
Expand All @@ -112,7 +113,6 @@ const BorderButton = (props: ButtonProps) => {
"translate-x-0.5": hideText && priority === "medium",
"translate-x-1": hideText && priority === "low",
// highlight the icon if priority is urgent
"text-white": priority === "urgent" && highlightUrgent,
})}
/>
</div>
Expand Down Expand Up @@ -145,7 +145,7 @@ const BackgroundButton = (props: ButtonProps) => {
const priorityDetails = ISSUE_PRIORITIES.find((p) => p.key === priority);

const priorityClasses = {
urgent: "bg-red-500/20 text-red-950",
urgent: "bg-red-600/20 text-red-600",
high: "bg-orange-500/20 text-orange-950",
medium: "bg-yellow-500/20 text-yellow-950",
low: "bg-blue-500/20 text-blue-950",
Expand All @@ -170,7 +170,7 @@ const BackgroundButton = (props: ButtonProps) => {
// compact the icons if text is hidden
"px-0.5": hideText,
// highlight the whole button if text is hidden and priority is urgent
"bg-red-600 border-red-600": priority === "urgent" && hideText && highlightUrgent,
"bg-red-600/10 border-red-600": priority === "urgent" && hideText && highlightUrgent,
},
className
)}
Expand All @@ -180,7 +180,8 @@ const BackgroundButton = (props: ButtonProps) => {
<div
className={cn({
// highlight just the icon if text is visible and priority is urgent
"bg-red-600 p-1 rounded": priority === "urgent" && !hideText && highlightUrgent,
"bg-red-600/20 p-0.5 rounded border border-red-600":
priority === "urgent" && !hideText && highlightUrgent,
})}
>
<PriorityIcon
Expand All @@ -194,7 +195,6 @@ const BackgroundButton = (props: ButtonProps) => {
"translate-x-0.5": hideText && priority === "medium",
"translate-x-1": hideText && priority === "low",
// highlight the icon if priority is urgent
"text-white": priority === "urgent" && highlightUrgent,
})}
/>
</div>
Expand Down Expand Up @@ -253,7 +253,7 @@ const TransparentButton = (props: ButtonProps) => {
// compact the icons if text is hidden
"px-0.5": hideText,
// highlight the whole button if text is hidden and priority is urgent
"bg-red-600 border-red-600": priority === "urgent" && hideText && highlightUrgent,
"bg-red-600/10 border-red-600": priority === "urgent" && hideText && highlightUrgent,
"bg-custom-background-80": isActive,
},
className
Expand All @@ -264,7 +264,8 @@ const TransparentButton = (props: ButtonProps) => {
<div
className={cn({
// highlight just the icon if text is visible and priority is urgent
"bg-red-600 p-1 rounded": priority === "urgent" && !hideText && highlightUrgent,
"bg-red-600/20 p-0.5 rounded border border-red-600":
priority === "urgent" && !hideText && highlightUrgent,
})}
>
<PriorityIcon
Expand All @@ -278,7 +279,6 @@ const TransparentButton = (props: ButtonProps) => {
"translate-x-0.5": hideText && priority === "medium",
"translate-x-1": hideText && priority === "low",
// highlight the icon if priority is urgent
"text-white": priority === "urgent" && highlightUrgent,
})}
/>
</div>
Expand Down