[WEB-2333] chore: intake issue back date snooze disabled

[anmolsinghbhatia]

Changes:

This PR disables the ability to snooze intake issues to a backdated time.

Reference:

[WEB-2333]

Media:

Before	After

Summary by CodeRabbit

• New Features

  • Updated the date selection in the Snooze Issue modal to prevent users from selecting past dates, allowing only today and future dates.

• Bug Fixes

  • Adjusted the modal's close behavior for improved functionality.

[coderabbitai]

Walkthrough

The pull request modifies the InboxIssueSnoozeModal component in the snooze-issue-modal.tsx file. It updates the DayPicker component to disable all past dates by using the current date (new Date()) as the reference point, replacing a previous implementation that only disabled dates before a variable tomorrow. Additionally, the onClick handler for the Button component has been changed to call the close() function instead of handleClose(), which may impact the modal's closing behavior.

Changes

File Path	Change Summary
web/core/components/inbox/modals/snooze-issue-modal.tsx	Updated DayPicker to disable all past dates using new Date(). Changed onClick handler to call close() instead of handleClose().

Possibly related PRs

• [WEB-1671] fix: expired snooze issues fixed #5270: This PR modifies the logic for handling snoozed issues, which is directly related to the changes made in the snooze-issue-modal.tsx file regarding the date selection logic for snoozed issues.
• fix: intake issue #5813: This PR addresses an intake issue related to the InboxIssueCreateRoot component, which may involve similar components or logic as the InboxIssueSnoozeModal, particularly in how issues are created and managed.

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Poem

🐇 In the modal where issues snooze,
Dates of the past, we now refuse.
With a click, the future's in sight,
Close the door, and all feels right!
Hopping forward, we cheer and play,
Today is bright, let's seize the day! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

web/core/components/inbox/modals/snooze-issue-modal.tsx (2)

57-61: LGTM! Consider using a more descriptive variable name.

The implementation correctly disables all dates before the current date, aligning with the PR objective of preventing users from snoozing issues to a backdated time. This change improves the user experience and prevents potential errors.

For improved readability, consider using a more descriptive variable name:

 disabled={[
   {
-    before: new Date(),
+    before: new Date(), // Disable all dates before today
   },
 ]}

---

Line range hint 62-68: Fix potential runtime error in Button onClick handler

The onClick handler has been changed to call close() instead of handleClose(). This change introduces a potential runtime error as close is not defined in the component's scope. Additionally, this modification doesn't align with the stated PR objectives.

To resolve this issue, revert the change:

 <Button
   variant="primary"
   onClick={() => {
-    close();
+    handleClose();
     onConfirm(date);
   }}
 >

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4c20be6 and 7999fb3.

📒 Files selected for processing (1)

• web/core/components/inbox/modals/snooze-issue-modal.tsx (1 hunks)

🧰 Additional context used