[WEB-2749] fix: display property intake

[gakshita]

Summary

This pr fixes display property in intake

Summary by CodeRabbit

• New Features
  • Enhanced the "Created by" section to display user details more responsively based on specific attributes.
  • Updated displayed names to show "Plane" for certain users, improving clarity in user identification.

[coderabbitai]

Walkthrough

The changes in the PeekOverviewProperties component focus on modifying the display logic for the "Created by" section. The logic now checks if the createdByDetails.display_name contains the substring "-intake". If it does, the userIds passed to the ButtonAvatars component is set to null, and the displayed name is updated to "Plane". Otherwise, it retains the original display_name and uses the corresponding createdByDetails.id. This adjustment enhances how user details are rendered based on specific attributes.

Changes

File Path	Change Summary
web/core/components/issues/peek-overview/properties.tsx	Modified logic for displaying user details in the "Created by" section based on the display_name.

Possibly related PRs

• [WEB-2209] chore: made cursor update on created_by in issue properties pane in issue detail, and issue peek overview #5331: This PR modifies the PeekOverviewProperties component by changing the cursor style, which is related to the user interface behavior of the same component being altered in the main PR.
• [WEB-2306] chore: IssueParentDetail added to issue peekoverview #5751: This PR introduces a new component, IssueParentDetail, within the PeekOverviewIssueDetails component, which is related to the overall structure and functionality of the peek overview feature that includes the PeekOverviewProperties component.
• fix: intake loading #5966: This PR addresses loading states in the InboxIssueService, which may indirectly relate to how user details are displayed in the PeekOverviewProperties component, especially in terms of responsiveness and data handling.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• SatishGandham
• sriramveeraghanta

🐇 In the meadow, I hop with glee,
Changes made for all to see!
A name that shifts, a logic clear,
"Plane" appears when "-intake" is near.
With user details now so bright,
The PeekOverview shines with delight! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/core/components/issues/peek-overview/properties.tsx (1)

138-144: Extract hardcoded string and consolidate duplicate logic

The current implementation has a few potential improvements:

1. The "-intake" string is hardcoded and used multiple times
2. The same check is duplicated in two places

Consider refactoring to:

+ // Add at the top of the file with other constants
+ const INTAKE_SUFFIX = "-intake";
+ 
+ // Add near other helper functions
+ const isIntakeUser = (displayName?: string) => displayName?.includes(INTAKE_SUFFIX);

  // In the component
- userIds={createdByDetails?.display_name.includes("-intake") ? null : createdByDetails?.id}
+ userIds={isIntakeUser(createdByDetails?.display_name) ? null : createdByDetails?.id}

- {createdByDetails?.display_name.includes("-intake") ? "Plane" : createdByDetails?.display_name}
+ {isIntakeUser(createdByDetails?.display_name) ? "Plane" : createdByDetails?.display_name}

This improves maintainability and reduces the risk of typos.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4b50b27 and 1d90aff.

📒 Files selected for processing (1)

• web/core/components/issues/peek-overview/properties.tsx (1 hunks)

🔇 Additional comments (1)

web/core/components/issues/peek-overview/properties.tsx (1)

138-141: Verify ButtonAvatars null handling

The code now passes null to ButtonAvatars when the user is from intake. Let's verify that ButtonAvatars properly handles null values.