chore: added dates in issue export#6088
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
apiserver/plane/bgtasks/export_task.py(2 hunks)
🔇 Additional comments (1)
apiserver/plane/bgtasks/export_task.py (1)
159-160: Verify date field handling across all export formats
Let's ensure the new date fields are properly handled across all export formats (CSV, JSON, XLSX) and that they are being correctly queried from the database.
Also applies to: 195-196
✅ Verification successful
Let me gather more information about the database query and field handling.
Let me check one final aspect about the header definitions and field mappings.
Date fields are properly handled across all export formats
Based on the verification results:
- The fields are correctly included in the database query's
values()call - Both
start_dateandtarget_dateare properly defined in the Issue model as DateField - The export header definitions include these fields
- Date formatting is consistently handled through
dateTimeConverterfor all formats - The fields are properly processed in both table rows (
generate_table_row) and JSON rows (generate_json_row)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify date field handling across the codebase
# Check if the fields are properly queried in the values() call
rg -A 5 "values\(" apiserver/plane/bgtasks/export_task.py
# Check for any other date formatting patterns in the codebase
rg "dateTimeConverter|dateConverter" --type py
# Check for any other export-related functions that might need updates
rg "generate_.*_row|create_.*_file" --type py
Length of output: 4017
Script:
#!/bin/bash
# Check the full query and field selection in export_task.py
rg -B 10 -A 10 "\.values\(" apiserver/plane/bgtasks/export_task.py
# Check the header definitions to ensure fields are included
rg "header.*=|ISSUE_HEADERS" apiserver/plane/bgtasks/export_task.py
Length of output: 1092
Script:
#!/bin/bash
# Get the complete header definition and field mappings
rg -A 50 "header = \[" apiserver/plane/bgtasks/export_task.py
# Check if there are any date-related field definitions in the models
rg "start_date|target_date" apiserver/plane/db/models/
Length of output: 3836
2 participants
chore:
Summary by CodeRabbit