[WEB-2382]chore:notifications file rearranging

[vamsikrishnamathala]

Summary

Rearranged files for notifications

Reference

web-2382

Summary by CodeRabbit

• New Features

  • Enhanced accessibility of the NotificationsSidebar component through updated export statements.
  • Introduced a new handleTabClick function for improved tab click handling in the NotificationsSidebar.

• Bug Fixes

  • Updated import paths for the NotificationsSidebar to reflect project restructuring.

• Documentation

  • Improved module interface by consolidating exports in the workspace-notifications component.

• Refactor

  • Streamlined tab click logic for better clarity and reusability in the NotificationsSidebar.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the import paths and export statements related to the NotificationsSidebar component across several files. The import path for NotificationsSidebar has been updated to reflect its new location. Additionally, the index.ts file now exports all entities from the root module, and a new export for NotificationsSidebar has been added in another file. The click handling logic in the root.tsx component has been refactored for better clarity and reusability.

Changes

File Path	Change Summary
web/app/[workspaceSlug]/(projects)/notifications/layout.tsx	Import path updated for NotificationsSidebar from @/components/workspace-notifications to @/plane-web/components/workspace-notifications.
web/ce/components/workspace-notifications/index.ts	Exported all entities from ./root.
web/ce/components/workspace-notifications/root.tsx	Added handleTabClick function using useCallback and imported TNotificationTab from @/constants/notification.
web/core/components/workspace-notifications/sidebar/index.ts	Removed export statement for root module.
web/ee/components/workspace-notifications/root.tsx	Added export for NotificationsSidebar from ce/components/workspace-notifications.

Possibly related PRs

• chore: components restructuring and UI improvements. #5285: Involves restructuring components, related to the import path change for NotificationsSidebar.
• [WEB-1986] chore: seperated project components for CE #5324: Also involves restructuring components and changing import paths, aligning with the main PR.
• [WEB-1986] chore: Build Fix, project page import #5356: Modifications include changes to import paths for project-related components, similar to the main PR.
• [WEB-2555] fix: add "mark all as read" in the notifications header #5770: Enhances the notifications header, directly related to the NotificationsSidebar component.

Suggested labels

🧹chore

Suggested reviewers

• SatishGandham
• sriramveeraghanta
• rahulramesha

Poem

🐰 In the code where bunnies play,
Paths have changed, hip-hip-hooray!
Notifications now in their place,
With a click, we set the pace.
Hopping through the lines so bright,
Our sidebar shines, a joyful sight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

web/ce/components/workspace-notifications/root.tsx (2)

40-47: LGTM! Well-implemented click handler with performance optimization

The handleTabClick implementation is solid with:

• Memoization using useCallback to prevent unnecessary re-renders
• Guard clause to prevent unnecessary state updates
• Proper type safety with TNotificationTab

Consider adding validation for tab values:

 const handleTabClick = useCallback(
   (tabValue: TNotificationTab) => {
+    if (!NOTIFICATION_TABS.some(tab => tab.value === tabValue)) {
+      console.warn(`Invalid tab value: ${tabValue}`);
+      return;
+    }
     if (currentNotificationTab !== tabValue) {
       setCurrentNotificationTab(tabValue);
     }
   },
   [currentNotificationTab, setCurrentNotificationTab]
 );

---

68-68: Optimize the onClick handler to prevent unnecessary function creation

While the current implementation works, we can optimize it by leveraging the memoized handleTabClick directly.

-onClick={()=>handleTabClick(tab.value)}
+onClick={() => {
+  // Using event parameter to show this is intentionally an arrow function
+  // since handleTabClick expects a TNotificationTab, not an event
+  handleTabClick(tab.value);
+}}

Note: We keep the arrow function here because handleTabClick expects a TNotificationTab parameter, not an event object. The comment explains this intention to future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 378e896 and 2ba48b9.

📒 Files selected for processing (5)

• web/app/[workspaceSlug]/(projects)/notifications/layout.tsx (1 hunks)
• web/ce/components/workspace-notifications/index.ts (1 hunks)
• web/ce/components/workspace-notifications/root.tsx (4 hunks)
• web/core/components/workspace-notifications/sidebar/index.ts (0 hunks)
• web/ee/components/workspace-notifications/root.tsx (1 hunks)

💤 Files with no reviewable changes (1)

• web/core/components/workspace-notifications/sidebar/index.ts

✅ Files skipped from review due to trivial changes (3)

• web/app/[workspaceSlug]/(projects)/notifications/layout.tsx
• web/ce/components/workspace-notifications/index.ts
• web/ee/components/workspace-notifications/root.tsx

🔇 Additional comments (1)

web/ce/components/workspace-notifications/root.tsx (1)

3-3: LGTM! Import changes are well-organized

The addition of useCallback and TNotificationTab imports supports the new tab click handling implementation while maintaining type safety.

Also applies to: 17-17