fix: pages empty state authorization

[aaryan610]

Bug fix:

Added authorization to pages' empty state CTA.

Summary by CodeRabbit

• New Features

  • Updated descriptions for various empty state messages to enhance clarity.
  • Refined access permissions for project and workspace pages to improve user experience.

• Bug Fixes

  • Standardized quotation marks in the description fields for consistency.

[coderabbitai]

Walkthrough

The changes in this pull request focus on updating the emptyStateDetails object in the web/core/constants/empty-state.ts file. Specifically, the description field for WORKSPACE_PROJECT_NOT_FOUND has been modified to use double quotes instead of single quotes. Additionally, the access permissions for several entries have been refined by removing EUserPermissions.GUEST from the access array for various project and workspace pages. The overall structure of the object remains unchanged.

Changes

File Path	Change Summary
web/core/constants/empty-state.ts	Updated description for WORKSPACE_PROJECT_NOT_FOUND to use double quotes; refined access permissions by removing EUserPermissions.GUEST from access arrays of multiple entries.

Possibly related PRs

• dev: revamp pages authorization #6094: The changes in this PR involve updating user permissions related to page actions, which aligns with the modifications made to access permissions in the main PR's emptyStateDetails object. Both PRs focus on refining access control based on user roles.

Suggested labels

⚙️backend

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Poem

🐇 In the land of code where rabbits play,
We fixed some strings and cleared the way.
With quotes aligned and access refined,
Our empty states now better defined!
Hopping along, we cheer with delight,
For every change makes our code just right! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 849d989 and a05cdae.

📒 Files selected for processing (1)

• web/core/constants/empty-state.ts (7 hunks)

🔇 Additional comments (2)

web/core/constants/empty-state.ts (2)

215-215: LGTM: Quote style consistency improvement

The change from single to double quotes aligns with the quote style used in other description fields throughout the file.

---

524-524: LGTM: Improved page access security

The removal of EUserPermissions.GUEST from page-related empty states is a good security improvement that:

1. Restricts page access to only ADMIN and MEMBER roles
2. Is consistently applied across both project and workspace pages
3. Aligns with the PR objective of fixing authorization for empty state CTAs

Let's verify that all page-related permissions are consistently updated:

Also applies to: 535-535, 546-546, 564-564, 575-575, 586-586

✅ Verification successful

LGTM: Permission changes are consistently applied

The verification confirms that all page-related empty states (PROJECT_PAGE, PROJECT_PAGE_PRIVATE, PROJECT_PAGE_PUBLIC, WORKSPACE_PAGE, WORKSPACE_PAGE_PRIVATE, WORKSPACE_PAGE_PUBLIC) consistently have their access restricted to only [EUserPermissions.ADMIN, EUserPermissions.MEMBER], with no instances of GUEST permissions. This aligns with the security improvement objective.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that no page-related empty states still include GUEST permissions
# Expected: No matches containing both "PAGE" and "GUEST" in the access array

rg -U 'PAGE.*\{(?s).+?access: \[(?:[^\]]*GUEST[^\]]*)\]' 

Length of output: 58

---

Script:

#!/bin/bash
# Let's try a simpler pattern to find any PAGE-related permissions
rg -U "PAGE.*access:" -A 2 web/core/constants/empty-state.ts

Length of output: 62

---

Script:

#!/bin/bash
# Let's check the content of the file directly to analyze permissions
cat web/core/constants/empty-state.ts

Length of output: 34688

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.