[WEB-2836] chore: workspace draft and project issue local db mutation

[anmolsinghbhatia]

Description

This PR includes enhancements for the local database, focusing on workspace drafts and project intake issue mutations.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

[WEB-2836]

Summary by CodeRabbit

• Bug Fixes

  • Improved data persistence logic for inbox and workspace draft issues.
  • Enhanced error handling during issue updates and state restoration.

• Chores

  • Refined method implementations for better data structure management without altering existing functionalities.

[coderabbitai]

Walkthrough

The changes involve modifications to the InboxIssueStore and WorkspaceDraftIssues classes, specifically focusing on how issues are persisted to the database. In InboxIssueStore, the updateInboxIssueStatus method now merges the current issue with the incoming issue data using the spread operator. Similarly, in WorkspaceDraftIssues, the moveIssue method has been adjusted to combine the payload with the response before persisting. Error handling remains consistent, ensuring stability during asynchronous operations.

Changes

File Path	Change Summary
web/core/store/inbox/inbox-issue.store.ts	Modified updateInboxIssueStatus to merge this.issue with inboxIssue.issue using spread.
web/core/store/issue/workspace-draft/issue.store.ts	Changed moveIssue to combine payload and response when calling addIssueToPersistanceLayer.

Possibly related PRs

• [WEB-1671] fix: expired snooze issues fixed #5270: Changes in the InboxIssueStatus component relate to handling inbox issues, connecting to InboxIssueStore modifications.
• [WEB-2589] Chore: inbox issue permissions #5763: Updates in WorkspaceDraftIssues align with changes in InboxIssueStore regarding issue persistence.
• [WEB-2388] fix: workspace draft issues #5800: Modifications in DraftIssueSerializer enhance draft issue handling, relating to InboxIssueStore changes.
• [WEB-2388] chore: theme changes and workspace draft issue total count updated #5805: Changes to workspace draft issue count may connect with overall issue management in InboxIssueStore.
• [WEB-2388] chore: workspace draft issue improvements #5808: Enhancements to workspace draft issue management could relate to InboxIssueStore updates.
• [WEB-2630] chore: double click action added to draft issue and code refactor #5821: New state variables in DraftIssueBlock may connect with InboxIssueStore management changes.
• [WEB-2629] fix: workspace draft delete and move mutation #5822: Fixes for deletion and movement of draft issues may relate to InboxIssueStore updates.
• [WEB-2629] chore: workspace draft issue ux copy updated #5825: Updates to UX copy for draft issues may indirectly relate to InboxIssueStore changes.
• [WEB-2676 ] fix: workspace draft move to project #5834: Changes in IssueFormRoot regarding moving issues may connect with InboxIssueStore persistence logic.
• [WEB-2677] chore: draft issue issue type #5836: Addition of isDraft property in components may relate to InboxIssueStore changes.
• [WEB-2682] fix: delete project mutation and workspace draft header validation #5843: Modifications in WorkspaceDraftHeader may connect with issue management in InboxIssueStore.
• [WEB-2625] chore: workspace favorite and draft improvement #5855: Changes to sidebar functionality for draft issues may relate to InboxIssueStore management.
• [WEB-2479] fix: merge default and archived issue details endpoint. #5882: Changes in IssueViewSet may connect with InboxIssueStore persistence logic.
• [WEB-2707] fix: draft issue module update and code refactor #5889: Modifications in DraftIssueBlock may relate to InboxIssueStore management.
• [WEB-2709] chore: intake issue navigation improvement #5891: Enhancements to navigation for intake issues may connect with InboxIssueStore changes.
• [WEB-2715] fix: draft issue type update outside click #5902: Changes in CreateUpdateIssueModalBase may relate to InboxIssueStore persistence logic.
• fix: intake loading #5966: Modifications in InboxIssueService regarding form handling may connect with InboxIssueStore changes.
• [WEB-2706] fix: Add fallback when db initialisation fails #5973: Changes in the Storage class may relate to InboxIssueStore persistence logic.
• [WEB-2401] chore: worklog enhancements #5982: Enhancements to IssueActivity may connect with InboxIssueStore management.
• [WEB-2817] fix: creating a new sub-issue from workspace level #6169: Changes in IssueDetailWidgetModals may relate to InboxIssueStore persistence logic.

Suggested reviewers

• sriramveeraghanta
• SatishGandham
• rahulramesha

🐰 In the meadow, where issues bloom,
A spread of data makes room!
With persistence in our sights,
We hop along through coding nights.
Merging changes, oh what fun,
Together, we’ve just begun! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 205395e and a2cfd91.

📒 Files selected for processing (2)

• web/core/store/inbox/inbox-issue.store.ts (1 hunks)
• web/core/store/issue/workspace-draft/issue.store.ts (1 hunks)

🔇 Additional comments (2)

web/core/store/inbox/inbox-issue.store.ts (1)

101-101: LGTM! Improved data persistence by preserving existing issue data.

The spread operator usage ensures that existing issue data is preserved while being updated with new values from the inbox issue. This prevents potential data loss during persistence.

web/core/store/issue/workspace-draft/issue.store.ts (1)

355-355: LGTM! Consistent data persistence pattern with InboxIssueStore.

The spread operator usage ensures that draft-specific data from the payload is preserved while being updated with the response data. This change aligns with the pattern used in InboxIssueStore, maintaining consistency across the codebase.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.