Skip to content

feat: add language support#6205

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
feat-language
Dec 15, 2024
Merged

feat: add language support#6205
sriramveeraghanta merged 1 commit intopreviewfrom
feat-language

Conversation

@pablohashescobar
Copy link
Member

@pablohashescobar pablohashescobar commented Dec 15, 2024

Description

Add language column in the profile model for saving the user language.

Type of Change

  • Feature (non-breaking change which adds functionality)

Summary by CodeRabbit

  • New Features

    • Introduced a new field for user language preferences in profiles.
    • Added new fields related to mobile onboarding in user profiles.
    • Implemented new models: Sticky and IssueDescriptionVersion.
  • Bug Fixes

    • Improved foreign key relationships for better data integrity in issueversion.
  • Database Changes

    • Removed outdated fields from the issueversion model to streamline data structure.

@pablohashescobar pablohashescobar added ⚙️backend 🔄migrations Contains Migration changes labels Dec 15, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2024

Walkthrough

This pull request introduces significant database schema modifications across multiple models. The changes primarily involve the issueversion and profile models, with four description-related fields being removed from issueversion and a new activity field added. The profile model gains new fields related to mobile onboarding, timezone settings, and language preferences. Two new models, Sticky and IssueDescriptionVersion, are also introduced to enhance the application's data structure and functionality.

Changes

File Change Summary
apiserver/plane/db/migrations/0087_remove_issueversion_description_and_more.py Database migration file implementing schema changes
apiserver/plane/db/models.py - Removed description fields from issueversion
- Added activity field to issueversion
- Added mobile onboarding and language fields to profile
- Created new Sticky and IssueDescriptionVersion models
apiserver/plane/db/models/user.py Added language field to Profile class

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta

Poem

🐰 Migrations dance, fields take flight,
Descriptions fade, new models bright
Mobile steps and language's song
In CodeRabbit's database, where changes belong!
Schema evolves with rabbit's might 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apiserver/plane/db/migrations/0087_remove_issueversion_description_and_more.py (1)

55-59: Consider limiting the language field's max_length to accommodate standard language codes

The max_length=255 may be unnecessarily long for a language code. Standard ISO 639-1 language codes are two characters (e.g., 'en', 'fr', 'es'), or up to seven characters if including locale codes (e.g., 'en-US', 'fr-CA'). Limiting the field length can help with data integrity and storage efficiency.

Apply this diff to adjust the max_length:

-field=models.CharField(default='en', max_length=255),
+field=models.CharField(default='en', max_length=7),
apiserver/plane/db/models/user.py (1)

193-194: Add choices or a validator to the language field to ensure valid language codes

By specifying choices or adding a validator, you can ensure that only supported language codes are stored in the language field. This helps prevent errors due to invalid or unexpected codes.

Example implementation using choices:

LANGUAGE_CHOICES = [
    ('en', 'English'),
    ('fr', 'French'),
    ('es', 'Spanish'),
    # Add other supported languages
]

language = models.CharField(
    max_length=7, default='en', choices=LANGUAGE_CHOICES
)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5908998 and 760465f.

📒 Files selected for processing (2)
  • apiserver/plane/db/migrations/0087_remove_issueversion_description_and_more.py (1 hunks)
  • apiserver/plane/db/models/user.py (1 hunks)

@sriramveeraghanta sriramveeraghanta merged commit 74b2ec0 into preview Dec 15, 2024
@sriramveeraghanta sriramveeraghanta deleted the feat-language branch December 15, 2024 05:34
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️backend 🔄migrations Contains Migration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants