regression: cn helper function import error#6244
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx (1)
Line range hint
123-125: Consider enhancing loading state UX.The current loading state only shows text. Consider adding a spinner or skeleton loader for better user experience.
{isLoading ? ( - <div className="text-center text-sm text-custom-text-400">Loading...</div> + <div className="flex items-center justify-center gap-2 text-center text-sm text-custom-text-400"> + <span className="animate-spin">⭮</span> + <span>Loading...</span> + </div> ) : sections.length ? (
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx(1 hunks)
🔇 Additional comments (2)
packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx (2)
Line range hint 35-45: Good addition of error handling in the selectItem function.
The try-catch block with specific error logging will help with debugging if mention selection fails.
6-7: Verify the new import path for the cn utility.
The import change from @/helpers/common to @plane/utils appears to address the regression. Let's verify this is the correct package.
Description
This PR fixes a regression bug causing a wrong import.
Summary by CodeRabbit
Bug Fixes
Chores