Skip to content

[PE-97] chore: re-order pages options #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 2 commits into from
Jan 3, 2025
Merged

[PE-97] chore: re-order pages options #6303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b955f48
chore: re-order pages dropdown options
aaryan610 Jan 2, 2025
980bd51
chore: re-order pages dropdown options
aaryan610 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/core/components/pages/editor/header/options-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,14 @@ export const PageOptionsDropdown: React.FC<Props> = observer((props) => {
extraOptions={EXTRA_MENU_OPTIONS}
optionsOrder={[
"full-screen",
"copy-markdown",
"copy-link",
"make-a-copy",
"toggle-lock",
"toggle-access",
"make-a-copy",
"archive-restore",
"delete",
"version-history",
"copy-markdown",
"export",
]}
page={page}
Expand Down
12 changes: 3 additions & 9 deletions web/core/components/pages/list/block-item-action.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,7 @@ export const BlockItemAction: FC<Props> = observer((props) => {
page,
});
// derived values
const {
access,
created_at,
is_favorite,
owned_by,
canCurrentUserFavoritePage,
} = page;
const { access, created_at, is_favorite, owned_by, canCurrentUserFavoritePage } = page;
const ownerDetails = owned_by ? getUserDetails(owned_by) : undefined;

return (
Expand Down Expand Up @@ -76,11 +70,11 @@ export const BlockItemAction: FC<Props> = observer((props) => {
{/* quick actions dropdown */}
<PageActions
optionsOrder={[
"toggle-lock",
"toggle-access",
"open-in-new-tab",
"copy-link",
"make-a-copy",
"toggle-lock",
"toggle-access",
"archive-restore",
"delete",
]}
Expand Down
Loading