[WEB-3101] fix: quick links error in home

[sangeethailango]

Description

This PR will fix the error raised while creating quick links for non-workspace owners.

Summary by CodeRabbit

• Code Improvements
  • Refactored QuickLinkViewSet class for improved code readability
  • Simplified workspace object retrieval in create method
  • Enhanced formatting of error responses and method calls
  • Restructured code structure without changing core functionality

[coderabbitai]

Walkthrough

The pull request introduces formatting and structural changes to the QuickLinkViewSet class in the quick_link.py file. The modifications primarily focus on code readability and organization, with subtle adjustments to method implementations. While the core functionality remains unchanged, there are minor modifications to workspace object retrieval and method parameter handling. The changes aim to improve code clarity without significantly altering the existing logic of quick link management.

Changes

File	Change Summary
apiserver/plane/app/views/workspace/quick_link.py	- Simplified create method workspace retrieval - Reformatted partial_update method - Consolidated retrieve method parameters - Enhanced error response formatting - Improved overall code readability

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• pablohashescobar

Poem

🐰 Hopping through code with glee,
Formatting lines, setting syntax free,
Quick links dancing, neat and bright,
Readability leaping to new height!
A rabbit's touch, clean and clear 🌟

Possibly related PRs

• [WEB-2928] feat: Home Quick links CRUD #6290: Changes to the QuickLinkViewSet class, focusing on quick link management

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

apiserver/plane/app/views/workspace/quick_link.py (2)

56-56: Maintain consistent error message format

For consistency with other methods, use "detail" instead of "error" in the error response.

Apply this diff:

-                {"error": "Quick link not found."}, status=status.HTTP_404_NOT_FOUND
+                {"detail": "Quick link not found."}, status=status.HTTP_404_NOT_FOUND

---

12-74: Consider implementing a custom exception handler

While the ownership checks are properly implemented throughout the ViewSet, the error handling patterns vary between methods. Consider implementing a custom exception handler at the ViewSet level to standardize error responses and reduce code duplication.

This would help:

1. Standardize error message formats
2. Centralize error handling logic
3. Make the code more maintainable
4. Improve user experience with consistent error responses

Would you like me to provide an example implementation of a custom exception handler?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87ea13c and 7635fe1.

📒 Files selected for processing (1)

• apiserver/plane/app/views/workspace/quick_link.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: lint-apiserver
• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

apiserver/plane/app/views/workspace/quick_link.py (2)

30-44: LGTM! Well-structured error handling

The implementation follows best practices with proper error handling and ownership validation.

---

69-74: LGTM! Clean implementation

The method correctly handles filtering by workspace and ownership, returning an empty list when no quick links are found.