[WEB-3104] chore: removed extra permission in stickies

[NarayanBavisetti]

Description

• removed extra permission in stickies

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Summary by CodeRabbit

• Security
  • Updated permission handling for workspace sticky notes
  • Refined access control mechanisms for specific view actions
  • Maintained role-based permissions for create, list, update, and delete operations

[coderabbitai]

Walkthrough

The pull request modifies the WorkspaceStickyViewSet in the workspace sticky views by removing the WorkSpaceBasePermission from the permission_classes attribute. This change eliminates direct class-level permission enforcement while maintaining role-based permissions through the allow_permission decorator for specific methods like create, list, partial update, and destroy. The modification suggests a refinement of the permission handling approach for workspace sticky operations.

Changes

File	Change Summary
apiserver/plane/app/views/workspace/sticky.py	Removed WorkSpaceBasePermission from permission_classes in WorkspaceStickyViewSet

Possibly related PRs

• [WEB-2474] chore: update page lock authorization #5635: Simplifies permission logic related to page locking
• [PE-88] fix: remove emoji edit for uneditable pages #6304: Removes user permission checks in the PageDetailsHeader component

Suggested labels

🌟improvement, 🐛bug

Suggested reviewers

• SatishGandham

Poem

🐰 A rabbit's tale of permissions light,
Stripped away with coding might,
No base permission to constrain,
Flexibility now shall reign!
Code dances free, permission's flight! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06ecbe8 and 084628d.

📒 Files selected for processing (1)

• apiserver/plane/app/views/workspace/sticky.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: lint-apiserver
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

apiserver/plane/app/views/workspace/sticky.py (1)

11-14: LGTM! The permission changes look secure.

The removal of WorkSpaceBasePermission is safe because:

1. get_queryset already filters by workspace and owner
2. All methods have explicit @allow_permission decorators
3. The base permission was redundant and potentially causing extra permission checks

Let's verify that all methods are properly protected:

✅ Verification successful

LGTM! The permission changes are secure and properly implemented.

The removal of WorkSpaceBasePermission is safe because:

1. All methods have explicit @allow_permission decorators
2. Create/list operations are properly restricted to workspace members
3. Update/delete operations have creator-only checks
4. Workspace-level permissions are enforced via decorators

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all ViewSet methods have permission decorators

# Search for any ViewSet methods without @allow_permission decorator
ast-grep --pattern 'class WorkspaceStickyViewSet {
  $$$
  def $METHOD($$$) {
    $$$
  }
  $$$
}'

# Search for permission decorators to cross-reference
rg "@allow_permission" -A 2

Length of output: 51941

---

Script:

#!/bin/bash
# Get all methods and their permission decorators in sticky.py
rg -U "(@allow_permission|def \w+\()" apiserver/plane/app/views/workspace/sticky.py

Length of output: 510

---

Script:

#!/bin/bash
# Get full decorator definitions with context
rg -U -B 1 -A 3 "@allow_permission" apiserver/plane/app/views/workspace/sticky.py

Length of output: 779

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.