[WEB-2877]fix: removed redundant custom menu

[vamsikrishnamathala]

Description

Removed redundant custom menu for workspace views.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-2877

Summary by CodeRabbit

• Refactor
  • Simplified the quick actions component by removing context menu functionality
  • Streamlined the rendering of custom buttons in the workspace view

[coderabbitai]

Walkthrough

The pull request modifies the WorkspaceViewQuickActions component in the quick-action.tsx file. The primary change involves removing the CustomMenu component and its associated context menu functionality. Previously, the component rendered a custom button with a dynamic menu of items that could be conditionally displayed and triggered. The updated implementation simplifies the component by directly rendering the custom button without the context menu, eliminating the dynamic item rendering and action handling logic.

Changes

File	Change Summary
web/core/components/workspace/views/quick-action.tsx	Removed CustomMenu component and context menu functionality, simplified button rendering

Possibly related PRs

• [WEB-2498] fix: workspace archives and setting validation #5654: Changes in SidebarWorkspaceMenu component involving CustomMenu rendering logic
• [WEB-2802]fix: dorpdown visibility issue in safari #6151: Modifications to the CustomMenu component

Suggested labels

🧹chore

Suggested reviewers

• SatishGandham
• sriramveeraghanta
• rahulramesha

Poem

🐰 A quick action's menu, once so grand
Stripped away with a rabbit's hand
Simplicity reigns, complexity falls
No more context, no more calls
Clean code hops, light and free! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c779fc0 and e8a4ba0.

📒 Files selected for processing (1)

• web/core/components/workspace/views/quick-action.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

web/core/components/workspace/views/quick-action.tsx (3)

Line range hint 41-66: LGTM! Well-structured menu implementation.

The menu items are well-organized with proper access controls through shouldRender property and clear action handlers. The use of ContextMenu with permission checks (isOwner and isAdmin) ensures secure access to sensitive operations.

Also applies to: 113-113

---

Line range hint 68-116: LGTM! Clean and accessible button implementation.

The button implementation is well-structured with:

• Proper conditional wrapping with Next.js Link
• Clear visual feedback for selected state
• Accessible privacy indicator for private views

---

117-117: PR objective successfully achieved.

The redundant custom menu has been successfully removed while maintaining the required functionality through ContextMenu. This change simplifies the component without losing any features.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/components/workspace/views/quick-action.tsx (1)

Line range hint 9-9: Remove unused import.

The CustomMenu component is imported but not used in the code. Remove it from the imports to maintain clean code.

- import { ContextMenu, CustomMenu, TContextMenuItem, TOAST_TYPE, setToast } from "@plane/ui";
+ import { ContextMenu, TContextMenuItem, TOAST_TYPE, setToast } from "@plane/ui";

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c779fc0 and e8a4ba0.

📒 Files selected for processing (1)

• web/core/components/workspace/views/quick-action.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

web/core/components/workspace/views/quick-action.tsx (2)

117-117: Clean and well-structured rendering implementation.

The component's rendering logic is well-organized with:

• Clear modal state management
• Proper conditional styling
• Appropriate Link wrapping based on selection state

---

Line range hint 113-113: Verify if ContextMenu should also be removed.

Based on the PR objective to remove redundant custom menus, should the ContextMenu component also be removed? Currently, the code maintains both the ContextMenu and direct button rendering, which might create an inconsistent user experience.

Let me help verify the usage of ContextMenu in other workspace view components: