[WEB-3194]fix: stickies modal close while redirection by vamsikrishnamathala · Pull Request #6440 · makeplane/plane

vamsikrishnamathala · 2025-01-21T15:44:28Z

Description

This update fixes the modal close issue in stickies while redirecting.

Type of Change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Improvement (change that would cause existing functionality to not work as expected)
Code refactoring
Performance improvements
Documentation update

References

WEB-3194

Summary by CodeRabbit

New Features
- Enhanced StickiesTruncated component with a new handleClose prop.
- Improved interaction between Stickies and StickiesTruncated components, allowing for better handling of close actions.
Improvements
- Added ability to handle close actions within the StickiesTruncated component.

coderabbitai · 2025-01-21T15:44:36Z

Walkthrough

The pull request introduces a new type definition StickiesTruncatedProps, which includes an optional method handleClose. The StickiesTruncated component is updated to accept props of this new type, allowing it to destructure and utilize handleClose within the component. Additionally, the Stickies component is modified to pass the handleClose function to StickiesTruncated, enabling it to invoke this method when a link is clicked.

Changes

File	Change Summary
`web/core/components/stickies/layout/stickies-truncated.tsx`	- Added `StickiesTruncatedProps` type with optional `handleClose` method - Updated component signature to accept new props - Modified `Link` component's `onClick` to call `handleClose`
`web/core/components/stickies/modal/stickies.tsx`	- Added `handleClose` prop when rendering `StickiesTruncated` component

Possibly related PRs

[WEB-2878]fix: draft creation #6230: This PR modifies the Stickies component to pass the handleClose prop to the StickiesTruncated component, which is directly related to the changes in the main PR that introduce the handleClose method in StickiesTruncatedProps.
[WEB-3045] fix: stickies bugs #6433: This PR includes modifications to the StickyDeleteModal and introduces a new handleLayout prop in the StickyNote component, which aligns with the changes in the main PR that enhance the functionality of the StickiesTruncated component by allowing it to handle close actions.
[WEB-3045] fix: sticky placeholder, gray color value #6436: This PR enhances the sticky placeholder functionality, which is relevant as it relates to the overall user experience improvements in the sticky components, including the StickiesTruncated component's new functionality introduced in the main PR.

Suggested labels

🌐frontend

Suggested reviewers

rahulramesha
SatishGandham

Poem

🐰 A Sticky Tale of Close and Flow
With props that dance and methods bright,
Our component learns to close just right.
A link, a click, a gentle sway,
Interactions bloom in rabbit's play! 🌈

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c5270a and aa39ff2.

📒 Files selected for processing (1)

web/core/components/stickies/layout/stickies-truncated.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

web/core/components/stickies/layout/stickies-truncated.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Analyze (javascript)
GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/components/stickies/layout/stickies-truncated.tsx (1)
41-41: Consider adding error boundary for handleClose.

While the implementation is correct, consider adding a null check before calling handleClose to prevent potential runtime errors if the prop is undefined.
-          onClick={handleClose}
+          onClick={() => handleClose?.()}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b611f51 and 3c5270a.

📒 Files selected for processing (2)

web/core/components/stickies/layout/stickies-truncated.tsx (2 hunks)
web/core/components/stickies/modal/stickies.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Analyze (javascript)
GitHub Check: Analyze (python)

🔇 Additional comments (3)

web/core/components/stickies/layout/stickies-truncated.tsx (2)

13-15: LGTM! Well-structured type definition.

The StickiesTruncatedProps type is properly defined with an optional handleClose method.

17-18: LGTM! Clean props implementation.

The component correctly implements the observer pattern and properly destructures the props.

web/core/components/stickies/modal/stickies.tsx (1)

70-70: LGTM! Proper prop passing.

The handleClose prop is correctly passed to the StickiesTruncated component, which implements the fix for modal closing during redirection.

gakshita · 2025-01-22T07:41:18Z

web/core/components/stickies/layout/stickies-truncated.tsx

          className={cn(
            "gap-1 w-full text-custom-primary-100 text-sm font-medium transition-opacity duration-300 bg-custom-background-90/20"
          )}
+          onClick={handleClose}


handleClose is optional here so can you render it conditionally?

fix: stickies modal close while redirection

3c5270a

vamsikrishnamathala added the 🐛bug Something isn't working label Jan 21, 2025

vamsikrishnamathala requested a review from rahulramesha January 21, 2025 15:44

vamsikrishnamathala self-assigned this Jan 21, 2025

coderabbitai bot reviewed Jan 21, 2025

View reviewed changes

gakshita reviewed Jan 22, 2025

View reviewed changes

chore: added deafult for optional prop

aa39ff2

vamsikrishnamathala requested a review from gakshita January 22, 2025 08:25

gakshita approved these changes Jan 22, 2025

View reviewed changes

sriramveeraghanta merged commit 8f3a0be into preview Jan 22, 2025
11 of 13 checks passed

sriramveeraghanta deleted the fix-stickies-modal branch January 22, 2025 08:52

coderabbitai bot mentioned this pull request Jan 28, 2025

[WEB-3203] fix: stickies height, overflow #6484

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[WEB-3194]fix: stickies modal close while redirection#6440

[WEB-3194]fix: stickies modal close while redirection#6440
sriramveeraghanta merged 2 commits intopreviewfrom
fix-stickies-modal

vamsikrishnamathala commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

gakshita Jan 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

vamsikrishnamathala commented Jan 21, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

References

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gakshita Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vamsikrishnamathala commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)