Skip to content

fix: updated keys #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prateekshourya29 merged 2 commits into from
Jan 31, 2025
Merged

fix: updated keys #6534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757e538
fix: updated keys
vamsikrishnamathala Jan 31, 2025
efde075
fix-sub work items toasts
vamsikrishnamathala Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/i18n/src/locales/en/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@
"add_more": "Add more",
"defaults": "Defaults",
"add_label": "Add label",
"estimates": "estimates",
"estimates": "Estimates",
"customize_time_range": "Customize time range",
"loading": "Loading...",
"attachments": "Attachments",
Expand Down
2 changes: 1 addition & 1 deletion web/ce/constants/project/settings/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const PROJECT_SETTINGS = {
Icon: SettingIcon,
},
labels: {
key: "i18n_labels",
key: "labels",
i18n_label: "common.labels",
href: `/settings/labels`,
access: [EUserPermissions.ADMIN, EUserPermissions.MEMBER],
Expand Down
6 changes: 3 additions & 3 deletions web/core/components/exporter/export-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ export const Exporter: React.FC<Props> = observer((props) => {
setExportLoading(false);
setToast({
type: TOAST_TYPE.SUCCESS,
title: t("workspace_settings.settings.exports.modal.success.title"),
message: t("workspace_settings.settings.exports.modal.success.message", {
title: t("workspace_settings.settings.exports.modal.toasts.success.title"),
message: t("workspace_settings.settings.exports.modal.toasts.success.message", {
entity: provider === "csv" ? "CSV" : provider === "xlsx" ? "Excel" : provider === "json" ? "JSON" : "",
}),
});
Expand All @@ -90,7 +90,7 @@ export const Exporter: React.FC<Props> = observer((props) => {
setToast({
type: TOAST_TYPE.ERROR,
title: t("error"),
message: t("workspace_settings.settings.exports.modal.error.message"),
message: t("workspace_settings.settings.exports.modal.toasts.error.message"),
});
});
}
Expand Down
8 changes: 4 additions & 4 deletions web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export const useSubIssueOperations = (
setToast({
type: TOAST_TYPE.SUCCESS,
title: t("toast.success"),
message: t("common.sub_work_items.update.success"),
message: t("sub_work_item.update.success"),
});
setSubIssueHelpers(parentIssueId, "issue_loader", issueId);
} catch (error) {
Expand All @@ -170,7 +170,7 @@ export const useSubIssueOperations = (
setToast({
type: TOAST_TYPE.ERROR,
title: t("toast.error"),
message: t("common.sub_work_items.update.error"),
message: t("sub_work_item.update.error"),
});
}
},
Expand All @@ -191,7 +191,7 @@ export const useSubIssueOperations = (
setToast({
type: TOAST_TYPE.SUCCESS,
title: t("toast.success"),
message: t("common.sub_work_items.remove.success"),
message: t("sub_work_item.remove.success"),
});
captureIssueEvent({
eventName: "Sub-issue removed",
Expand All @@ -216,7 +216,7 @@ export const useSubIssueOperations = (
setToast({
type: TOAST_TYPE.ERROR,
title: t("toast.error"),
message: t("common.sub_work_items.remove.error"),
message: t("sub_work_item.remove.error"),
});
}
},
Expand Down
3 changes: 2 additions & 1 deletion web/core/components/workspace/views/delete-view-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export const DeleteGlobalViewModal: React.FC<Props> = observer((props) => {
state: "SUCCESS",
});
})
.catch(() => {
.catch((error) => {
console.log({error})
captureEvent(GLOBAL_VIEW_DELETED, {
view_id: data.id,
state: "FAILED",
Expand Down
Loading