[WEB-3195]fix: view delete toast message

[vamsikrishnamathala]

Description

This update fixes the toast message while deleting a view.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

WEB-3195

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling during view deletion process
  • Enhanced user feedback with more specific error messages when view deletion fails

[coderabbitai]

Walkthrough

The pull request focuses on enhancing error handling in the DeleteGlobalViewModal component. The primary modification is in the handleDeletion function, where the catch block now accepts an error parameter. This change allows for more specific and detailed error messaging during view deletion failures, improving the user experience by providing more informative toast notifications when deletion encounters an error.

Changes

File	Change Summary
web/core/components/workspace/views/delete-view-modal.tsx	Updated handleDeletion method to capture and utilize error details in catch block for more precise error messaging

Possibly related PRs

• [WEB-2330] fix: you don't have permission toast on on bulk delete #5599: Modifies error handling for deletion actions
• [WEB-2598] fix: show toast when existing issue is added to cycles #5807: Improves error handling and toast notification feedback
• [WEB-2878]fix: draft creation #6230: Refines error handling in issue creation process

Suggested reviewers

• rahulramesha
• SatishGandham
• anmolsinghbhatia

Poem

🐰 A Rabbit's Ode to Error Grace 🐰

In deletion's dance, a catch so bright,
Errors whisper their message tight
No more generic, vague and bland
Each failure now with details grand
User's path now clearer than before

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/core/components/workspace/views/delete-view-modal.tsx (1)

45-45: Consider using a more specific type for the error parameter.

Instead of using any, consider defining a specific error type or using unknown as a safer alternative in TypeScript.

-      .catch((error: any) => {
+      .catch((error: unknown) => {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f4dd77 and 6fe7159.

📒 Files selected for processing (1)

• web/core/components/workspace/views/delete-view-modal.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/core/components/workspace/views/delete-view-modal.tsx (1)

46-54: LGTM! Error handling looks good.

The error handling is well-implemented with:

• Proper event tracking for failed deletions
• Clear error message with fallback
• Optional chaining to safely access error details