chore: user workspace api modification#6547
Merged
sangeethailango merged 3 commits intofeat-enchanced-workspace-switcherfrom Feb 5, 2025
Merged
chore: user workspace api modification#6547sangeethailango merged 3 commits intofeat-enchanced-workspace-switcherfrom
sangeethailango merged 3 commits intofeat-enchanced-workspace-switcherfrom
Conversation
Contributor
WalkthroughThis update modifies the workspace data structure by removing the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Endpoint as UserWorkSpacesEndpoint
participant DB as WorkspaceMember Database
participant Serializer as WorkSpaceSerializer
Client->>Endpoint: GET /user/workspaces
Endpoint->>DB: Query workspaces with role (filter by user & active status)
DB-->>Endpoint: Return workspace member data with role
Endpoint->>Serializer: Serialize workspace data with new role field
Serializer-->>Endpoint: Return serialized data
Endpoint-->>Client: Response with updated workspace info
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apiserver/plane/app/serializers/workspace.py (1)
49-57: Removeownerfromread_only_fields.The
ownerfield has been removed from the serializer but is still listed inread_only_fields. This could cause confusion for future maintenance.Apply this diff to remove the redundant field:
read_only_fields = [ "id", "created_by", "updated_by", "created_at", "updated_at", - "owner", "logo_url", ]apiserver/plane/app/views/workspace/base.py (1)
178-181: Fix line length to comply with PEP 8.The line exceeds the maximum line length of 88 characters.
Apply this diff to fix the line length:
role = ( - WorkspaceMember.objects.filter(workspace=OuterRef("id"), member=request.user, is_active=True) + WorkspaceMember.objects.filter( + workspace=OuterRef("id"), + member=request.user, + is_active=True + ) .values("role") )🧰 Tools
🪛 Ruff (0.8.2)
179-179: Line too long (105 > 88)
(E501)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apiserver/plane/app/serializers/workspace.py(1 hunks)apiserver/plane/app/views/workspace/base.py(3 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
apiserver/plane/app/views/workspace/base.py
179-179: Line too long (105 > 88)
(E501)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
sangeethailango
changed the base branch from
preview
to
feat-enchanced-workspace-switcher
sangeethailango
merged commit 8623bea
into
feat-enchanced-workspace-switcher
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will return the user role in the user workspace API.
Summary by CodeRabbit