[PE-257] fix: recent sticky collapse icon#6647
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/stickies/sticky/root.tsx (1)
89-102: Consider using a CSS variable for margin adjustment.The wrapper with
-mt-2effectively compensates for the button's padding. However, to improve maintainability, consider using a CSS variable to keep the spacing values in sync.- <div className="-mt-2"> + <div className="[--sticky-margin:-0.5rem] -mt-[var(--sticky-margin)]">This way, if the button's padding changes in the future, you can update the margin in one place.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/core/components/stickies/sticky/root.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/stickies/sticky/root.tsx (1)
84-86: LGTM! Button styling improvements.The updated button styling with
flex-shrink-0,justify-end, and consistent padding improves the collapse icon's positioning and prevents unwanted shrinking.
Description
This PR fixes the recent sticky collapse icon position
Type of Change
Screenshots and Media (if applicable)
Summary by CodeRabbit