Skip to content

[PE-257] fix: recent sticky collapse icon#6647

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix/sticky-collapse
Feb 19, 2025
Merged

[PE-257] fix: recent sticky collapse icon#6647
sriramveeraghanta merged 1 commit intopreviewfrom
fix/sticky-collapse

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Feb 19, 2025

Description

This PR fixes the recent sticky collapse icon position

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots and Media (if applicable)

Before After
image image

Summary by CodeRabbit

  • Style
    • Enhanced the close button’s alignment and spacing for a cleaner interface.
    • Adjusted the layout of the sticky note input area for improved visual balance.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2025

Walkthrough

The pull request updates the StickyNote component by modifying the styling of its close button and adjusting the layout of the StickyInput element. The button’s class is changed to use flex-shrink-0 flex justify-end p-2.5 and the StickyInput is now wrapped within a <div> with a -mt-2 class, affecting its vertical positioning. There are no changes to the underlying logic for update or deletion operations, and public interfaces remain unaltered.

Changes

File Change Summary
web/.../sticky/root.tsx Updated close button's class to flex-shrink-0 flex justify-end p-2.5; wrapped StickyInput in a <div> with a -mt-2 class for layout adjustments.

Possibly related PRs

Suggested labels

🐛bug, ✍️editor

Suggested reviewers

  • sriramveeraghanta
  • anmolsinghbhatia

Poem

I'm a little rabbit with code in my heart,
Hopping through commits and making a fresh start.
My eyes saw new classes and margins so neat,
As sticky notes now dance with a rhythmic beat.
With each tweak and update, I cheer with delight –
🐇💻 Code bunnies forever in the moonlit night!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
web/core/components/stickies/sticky/root.tsx (1)

89-102: Consider using a CSS variable for margin adjustment.

The wrapper with -mt-2 effectively compensates for the button's padding. However, to improve maintainability, consider using a CSS variable to keep the spacing values in sync.

-        <div className="-mt-2">
+        <div className="[--sticky-margin:-0.5rem] -mt-[var(--sticky-margin)]">

This way, if the button's padding changes in the future, you can update the margin in one place.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6303847 and 8907cc0.

📒 Files selected for processing (1)
  • web/core/components/stickies/sticky/root.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/stickies/sticky/root.tsx (1)

84-86: LGTM! Button styling improvements.

The updated button styling with flex-shrink-0, justify-end, and consistent padding improves the collapse icon's positioning and prevents unwanted shrinking.

@sriramveeraghanta sriramveeraghanta merged commit dd11ebf into preview Feb 19, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/sticky-collapse branch February 19, 2025 11:59
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants