[WEB-3439] fix: work item attachment mutation

[anmolsinghbhatia]

Description

This PR includes following changes:

• Fixed the work item attachment add mutation.
• Added "created_by" to the attachment response.

Type of Change

• Bug fix
• Code refactoring

References

[WEB-3439]

Summary by CodeRabbit

• New Features

  • Issue attachments now include creator information in their details.

• Bug Fixes

  • Adjusted how attachment counts are updated when adding attachments, ensuring consistent display when attachments are removed.

[coderabbitai]

Walkthrough

This pull request makes two distinct changes. On the server side, it adds the created_by field to the output of the IssueAttachmentLiteSerializer in the API, ensuring this information is now serialized. On the client side, it removes the line in the createAttachment method that updates the attachment count, while the removal logic in the removeAttachment method remains unchanged.

Changes

File(s)	Change Summary
apiserver/.../issue.py	Added the created_by field to the Meta.fields in IssueAttachmentLiteSerializer to include it in API responses.
web/core/store/issue/.../attachment.store.ts	Removed the line updating attachment_count in the createAttachment method, altering how attachment counts are managed during creation.

Possibly related PRs

• [WEB-2718] fix: issue attachment uploads #5904: Aligns with standardizing the created_by attribute across asset management methods.
• [WEB-3377] fix: attachment item avatar #6650: Introduces the created_by property in the TIssueAttachment type definition, closely related to the serializer update.

Suggested labels

🐛bug, 🌟enhancement

Suggested reviewers

• sriramveeraghanta
• prateekshourya29
• aaryan610

Poem

I’m a rabbit, hopping through the code,
Adding new fields where data is bestowed.
Removed a count update in a single swift stroke,
With each little change, the gateways awoke.
Hopping on forward, in bytes I invoke! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6c26a and c1b25b0.

📒 Files selected for processing (2)

• apiserver/plane/app/serializers/issue.py (1 hunks)
• web/core/store/issue/issue-details/attachment.store.ts (0 hunks)

💤 Files with no reviewable changes (1)

• web/core/store/issue/issue-details/attachment.store.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

apiserver/plane/app/serializers/issue.py (1)

517-531: LGTM! The addition of created_by field enhances the attachment response.

The change appropriately adds the created_by field to the serializer's output while maintaining the read-only nature of all fields. This enhancement aligns with the PR objectives and provides valuable information about the attachment's creator.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.