Skip to content

[WEB-3411] fix: archive permission #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 3 commits into from
Feb 24, 2025
Merged

[WEB-3411] fix: archive permission #6661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d298af
fix restore typo
iam-vipin Feb 24, 2025
09cce6d
fix archive permissions
iam-vipin Feb 24, 2025
077d721
fix restore typo
iam-vipin Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/i18n/src/locales/en/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
"Cancel": "Cancel",
"edit": "Edit",
"archive": "Archive",
"restor": "Restore",
"restore": "Restore",
"open_in_new_tab": "Open in new tab",
"delete": "Delete",
"deleting": "Deleting",
Expand Down Expand Up @@ -613,6 +613,7 @@
"open_in_new_tab": "Open in new tab",
"copy_link": "Copy link",
"archive": "Archive",
"restore": "Restore",
"delete": "Delete",
"remove_relation": "Remove relation",
"subscribe": "Subscribe",
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/src/locales/es/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
"Cancel": "Cancelar",
"edit": "Editar",
"archive": "Archivar",
"restor": "Restaurar",
"restore": "Restaurar",
"open_in_new_tab": "Abrir en nueva pestaña",
"delete": "Eliminar",
"deleting": "Eliminando",
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/src/locales/fr/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
"Cancel": "Annuler",
"edit": "Modifier",
"archive": "Archiver",
"restor": "Restaurer",
"restore": "Restaurer",
"open_in_new_tab": "Ouvrir dans un nouvel onglet",
"delete": "Supprimer",
"deleting": "Suppression",
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/src/locales/ja/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
"Cancel": "キャンセル",
"edit": "編集",
"archive": "アーカイブ",
"restor": "復元",
"restore": "復元",
"open_in_new_tab": "新しいタブで開く",
"delete": "削除",
"deleting": "削除中",
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/src/locales/zh-CN/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
"Cancel": "取消",
"edit": "编辑",
"archive": "归档",
"restor": "恢复",
"restore": "恢复",
"open_in_new_tab": "在新标签页中打开",
"delete": "删除",
"deleting": "删除中",
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/cycles/quick-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const CycleQuickActions: React.FC<Props> = observer((props) => {
{
key: "restore",
action: handleRestoreCycle,
title: t("restor"),
title: t("restore"),
icon: ArchiveRestoreIcon,
shouldRender: isEditingAllowed && isArchived,
},
Expand Down
3 changes: 2 additions & 1 deletion web/core/components/issues/issue-layouts/quick-action-dropdowns/archived-issue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ export const ArchivedIssueQuickActions: React.FC<IQuickActionProps> = observer((
// auth
const isEditingAllowed =
allowPermissions([EUserPermissions.ADMIN, EUserPermissions.MEMBER], EUserPermissionsLevel.PROJECT) && !readOnly;
const isRestoringAllowed = handleRestore && isEditingAllowed;
const isRestoringAllowed =
handleRestore && allowPermissions([EUserPermissions.ADMIN, EUserPermissions.MEMBER], EUserPermissionsLevel.PROJECT);

const issueLink = `${workspaceSlug}/projects/${issue.project_id}/archives/issues/${issue.id}`;

Expand Down