Skip to content

fix: issue activity for project id validation #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 1 commit into from
Feb 25, 2025
Merged

fix: issue activity for project id validation #6668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apiserver/plane/bgtasks/issue_activities_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from plane.utils.issue_relation_mapper import get_inverse_relation
from plane.utils.valid_uuid import is_valid_uuid


# Track Changes in name
def track_name(
requested_data,
Expand Down Expand Up @@ -1569,13 +1570,12 @@ def issue_activity(
issue_activities = []

# check if project_id is valid
if not is_valid_uuid(project_id):
if not is_valid_uuid(str(project_id)):
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Excellent bugfix for project ID validation.

Converting the project_id to a string before validation ensures that the is_valid_uuid function always receives the expected string type, regardless of how the project_id is passed to the function. This addresses the validation issue mentioned in the PR objectives and makes the code more robust against type-related errors.

return

project = Project.objects.get(pk=project_id)
workspace_id = project.workspace_id


if issue_id is not None:
if origin:
ri = redis_instance()
Expand Down