-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Display properties - STD fields #6786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7800f98
dc2514c
06433d4
a01a77c
c3e4785
b546d26
cbb3e68
100c32e
ba2628b
d3db51f
271a21b
3fb79be
a0bee21
2c0ef2a
3f9e619
c3141d7
33797ca
d7111d2
dd1a3cc
1bc77d5
b92248b
07c00f8
e61227b
99f593a
d6804eb
26e25ac
74123dd
0fc8bb0
093245b
d4948e5
a86cbc3
55019e5
5fd3638
7717611
f54c03c
e99955f
f25596f
5be1055
17d2ee0
102dc72
abcaa3f
0d7efc8
ab4a1e5
8b6fac6
aa5ec50
809a63b
f4b5273
4f272e9
f6961ef
e8fde6e
ecd4c78
71880d5
40a209b
c4e76bc
a180116
8e926b1
e8c8eaf
b2e1a72
c9df844
555ee5c
19166f6
574033c
0b836dd
805710d
a08074b
caa9341
240b47a
3e66925
c861bc9
c0fb7b6
8964187
50e257e
1747cef
150410d
2ae579f
3c34f59
6fc92fd
ec07052
c2a36cd
ac39e7e
7c5f5ea
9bec624
2c5c9b7
78227f6
46f36b1
d1e4f3d
43b1c01
e7aab55
ff39814
cd03828
fb53aaf
7157b85
1904787
1a362e2
db341b2
08a42fd
5c50c21
daa3d2e
08bd96a
4ffe507
2007e99
5ad130f
bed3c33
a0882d1
7809f0e
475fdcb
217204b
af3d837
4cb2d63
c6db515
316984e
91f9473
4428976
51c2e58
cd2a8e0
1fb0c8e
61a9692
d18a141
78ec6d8
621121f
332e001
f266562
6d453c8
3baa08c
6ad4527
cf27a0f
caf9cf8
b82176c
6b60c41
cba2dd4
6eeb38d
ddcd4fb
2b96095
bb68517
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,9 @@ events { | |
|
|
||
| http { | ||
| sendfile on; | ||
| chunked_transfer_encoding on; | ||
| client_body_buffer_size 10M; | ||
| client_max_body_size 50M; | ||
|
Comment on lines
+6
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainAdded global client request handling configurations. The new Nginx configuration improves handling of large request bodies, but there might be a conflict with the existing client_max_body_size directive on line 15. 🏁 Script executed: #!/bin/bash
# Check if the FILE_SIZE_LIMIT environment variable is defined and how it relates to the new 50M setting
grep -r "FILE_SIZE_LIMIT" --include="*.py" --include="*.sh" --include="*.env" .Length of output: 1792 Action Required: Resolve client_max_body_size Conflict & FILE_SIZE_LIMIT Mismatch The updated nginx configuration (lines 6–8 in Please address the following:
|
||
|
|
||
| server { | ||
| listen 80; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,13 +27,15 @@ RUN apk add --no-cache --virtual .build-deps \ | |
| "postgresql-dev" \ | ||
| "libc-dev" \ | ||
| "linux-headers" \ | ||
| && \ | ||
| pip install -r requirements.txt --compile --no-cache-dir \ | ||
| && \ | ||
| apk del .build-deps | ||
| && pip install -r requirements.txt --compile --no-cache-dir \ | ||
| && apk del .build-deps | ||
|
|
||
| # Install Flower for Celery Monitoring | ||
| RUN pip install flower | ||
|
|
||
| # Add in Django deps and generate Django's static files | ||
| ENV FLOWER_UNAUTHENTICATED_API=true | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security concern with unauthenticated Flower API Setting Consider implementing authentication for Flower by:
|
||
|
|
||
| # Copy application files | ||
| COPY manage.py manage.py | ||
| COPY plane plane/ | ||
| COPY templates templates/ | ||
|
|
@@ -46,7 +48,30 @@ RUN mkdir -p /code/plane/logs | |
| RUN chmod +x ./bin/* | ||
| RUN chmod -R 777 /code | ||
|
|
||
| # Expose container port and run entry point script | ||
| EXPOSE 8000 | ||
| # Expose ports for API and Flower UI | ||
| EXPOSE 8000 5555 | ||
|
|
||
| # Declare a build argument | ||
| ARG ENV_FILE_PATH | ||
|
|
||
| # Use the build argument | ||
| COPY ${ENV_FILE_PATH} /code/plane/file.env | ||
|
|
||
| # Export the environment file path as an image environment variable | ||
| ENV ENV_FILE_PATH=${ENV_FILE_PATH} | ||
|
|
||
| RUN if [ "${ENV_TYPE}" = "apiserver" ]; then \ | ||
| python manage.py migrate --noinput; \ | ||
| fi | ||
|
|
||
| CMD if [ "${ENV_TYPE}" = "apiserver" ]; then \ | ||
| gunicorn -w 2 -k uvicorn.workers.UvicornWorker plane.asgi:application --bind 0.0.0.0:8000 --max-requests 1200 --max-requests-jitter 1000 --access-logfile -; \ | ||
| elif [ "${ENV_TYPE}" = "celery" ]; then \ | ||
| celery -A plane flower --port=5555 --address=0.0.0.0 --url_prefix=flower & \ | ||
| celery -A plane worker -l info; \ | ||
| elif [ "${ENV_TYPE}" = "celery-beat" ]; then \ | ||
| (celery -A plane flower --port=5555 --address=0.0.0.0 --url-prefix=flower &) && celery -A plane beat -l info; \ | ||
| else \ | ||
| echo "Unknown ENV_TYPE: ${ENV_TYPE}"; \ | ||
| exit 1; \ | ||
| fi | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component rendering an empty anchor element
The upgrade button functionality has been commented out, resulting in an empty
<a>tag being rendered. This creates an empty DOM element without any user-visible or functional purpose.Consider one of the following approaches instead:
📝 Committable suggestion