Skip to content

Comments

[RANTS-65] fix: undefined work item sequence in bulk delete work item modal#6797

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-undefined-work-item-sequence
Mar 24, 2025
Merged

[RANTS-65] fix: undefined work item sequence in bulk delete work item modal#6797
sriramveeraghanta merged 1 commit intopreviewfrom
fix-undefined-work-item-sequence

Conversation

@prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Mar 24, 2025

Description

The Work Item sequence ID was appearing as undefined in the bulk delete Work Item modal because we were relying on the store to retrieve Work Item details. However, since this is a search endpoint, not all details are available in the store. Instead of relying on the store, we should directly display the sequence ID using the data already available, as we have all the necessary information to construct it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

image

Summary by CodeRabbit

  • Refactor
    • Enhanced the bulk deletion modal to display additional, more detailed issue identifiers. This update improves clarity during the deletion process, ensuring users have greater context when managing issues.

@makeplane
Copy link

makeplane bot commented Mar 24, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2025

Walkthrough

The pull request updates the properties passed to the IssueIdentifier component within the bulk delete issues modal. The previous implementation provided issueId and projectId, while the new version replaces issueId with issueTypeId, projectIdentifier, and issueSequenceId, alongside projectId and textContainerClassName. This change adjusts the structure of the issue data passed to the component.

Changes

File Changes Summary
web/core/.../bulk-delete-issues-modal-item.tsx Updated props for IssueIdentifier: replaced issueId with issueTypeId, projectIdentifier, and issueSequenceId, while retaining projectId and textContainerClassName.

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

  • sriramveeraghanta
  • anmolsinghbhatia

Poem

I’m a bunny with code so bright,
Hopping through changes with pure delight,
Props now dance in a clearer stream,
From issueId to a detailed dream,
In a garden of logic, I skip away,
Celebrating new paths in our code today!
🐰✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
web/core/components/core/modals/bulk-delete-issues-modal-item.tsx (1)

37-43: Consider adding null checks for a more robust implementation.

While this fix correctly passes the required properties, consider adding null/undefined checks to prevent potential issues if any of these properties are missing from the response.

<IssueIdentifier
  projectId={issue.project_id}
  issueTypeId={issue.type_id}
  projectIdentifier={issue.project__identifier}
  issueSequenceId={issue.sequence_id}
  textContainerClassName="text-xs"
+  // Add fallback values if properties are undefined
/>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f720a9a and 30e0f83.

📒 Files selected for processing (1)
  • web/core/components/core/modals/bulk-delete-issues-modal-item.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/core/modals/bulk-delete-issues-modal-item.tsx (1)

37-43: Appropriate fix for the undefined issue sequence in modal.

This change correctly addresses the PR objective by passing all the necessary properties directly to the IssueIdentifier component instead of relying on a store lookup that was failing. Now the component receives explicit values for issueTypeId, projectIdentifier, and issueSequenceId which should resolve the undefined sequence display issue.

@sriramveeraghanta sriramveeraghanta merged commit 0d069bf into preview Mar 24, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-undefined-work-item-sequence branch March 24, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants