[RANTS-65] fix: undefined work item sequence in bulk delete work item modal#6797
Conversation
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
WalkthroughThe pull request updates the properties passed to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/core/modals/bulk-delete-issues-modal-item.tsx (1)
37-43: Consider adding null checks for a more robust implementation.While this fix correctly passes the required properties, consider adding null/undefined checks to prevent potential issues if any of these properties are missing from the response.
<IssueIdentifier projectId={issue.project_id} issueTypeId={issue.type_id} projectIdentifier={issue.project__identifier} issueSequenceId={issue.sequence_id} textContainerClassName="text-xs" + // Add fallback values if properties are undefined />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/core/components/core/modals/bulk-delete-issues-modal-item.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/core/modals/bulk-delete-issues-modal-item.tsx (1)
37-43: Appropriate fix for the undefined issue sequence in modal.This change correctly addresses the PR objective by passing all the necessary properties directly to the
IssueIdentifiercomponent instead of relying on a store lookup that was failing. Now the component receives explicit values forissueTypeId,projectIdentifier, andissueSequenceIdwhich should resolve the undefined sequence display issue.
Description
The Work Item sequence ID was appearing as
undefinedin the bulk delete Work Item modal because we were relying on the store to retrieve Work Item details. However, since this is a search endpoint, not all details are available in the store. Instead of relying on the store, we should directly display the sequence ID using the data already available, as we have all the necessary information to construct it.Type of Change
Screenshots and Media (if applicable)
Summary by CodeRabbit