[WEB-3560] fix: table layout issue block and code refactor

[anmolsinghbhatia]

Description

This PR fixes the table layout issue and includes code refactoring.

Type of Change

• Bug fix
• Code refactoring

References

[WEB-3560]

Summary by CodeRabbit

• Style
  • Refined the visual behavior of interactive elements to offer a more consistent appearance.
  • Updated layout spacing for improved alignment, ensuring a cleaner and enhanced user interface experience.

[coderabbitai]

Walkthrough

The pull request modifies the IssueRowDetails component in the spreadsheet issue layout. It simplifies the ControlLink by replacing a complex conditional class string with a static class, "outline-none". The conditional styling logic is restored to the Row component based on the issue's peeked state, nesting level, and scroll state, and the padding of an inner checkbox wrapper is adjusted from py-2.5 to py-2. No changes were made to any exported or public entities.

Changes

File	Change Summary
web/.../issue-row.tsx	Simplified ControlLink class to "outline-none", moved conditional styling logic to the Row component, and updated checkbox wrapper padding from py-2.5 to py-2.

Sequence Diagram(s)

(No sequence diagrams generated as the changes solely affect styling and layout adjustments without modifying control flow.)

Possibly related PRs

• [WEB-2390] fix: Clickable Area for Issue List Layout Item #5536: Addresses structural modifications in the ControlLink and Row components within the issue layout.
• [WEB-3352] fix: board layout redirection bug in work item  #6584: Focuses on modifying the href property for the ControlLink, which relates directly to the styling adjustments in this PR.

Suggested labels

🐛bug

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Poem

I'm a bunny in the code garden, hopping along the way,
Simplifying ControlLink with a neat, static display.
The Row now wears logic as its stylish new gear,
And the checkbox padding whispers, "Everything's clear!"
With each code line a nibble, I celebrate the day! 🐇

Happy coding from the rabbit's burrow!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbdf2f0 and 51d50ad.

📒 Files selected for processing (1)

• web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (3)

web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx (3)

264-264: Good simplification of the ControlLink className

The className has been simplified to focus solely on outline behavior, which makes the code cleaner and more maintainable. This is a positive change that aligns with separation of concerns principles.

---

267-278: Improved styling organization with conditional logic in Row component

Moving the conditional styling logic from ControlLink to Row component is an excellent refactoring decision. This properly separates navigation concerns (ControlLink) from visual presentation (Row), making the code more maintainable and easier to understand.

The conditional styling now correctly handles:

• Base appearance with appropriate dimensions and cursor behavior
• Border styling based on the issue's peeked state
• Special highlighting when an issue is peeked at the correct nesting level
• Shadow effect when scrolled

This change should effectively fix the table layout issues mentioned in the PR objectives.

---

278-278: Adjusted padding for better vertical alignment

The padding adjustment from py-2.5 to py-2 provides better vertical alignment for the items container. This subtle change helps maintain consistent spacing in the table layout.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

References

• [WEB-3560] UI Issue in table layout first item when filter is applied

Comment Automatically Generated by Plane