[WEB-3658] fix: remove cycles and modules when issues are bulk deleted.

[NarayanBavisetti]

Description

• fixes issue with bulk deletion by properly disconnecting issues from cycles and modules.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Issue Link:- WEB-3658

[coderabbitai]

Walkthrough

This change updates the deletion process in the BulkDeleteIssuesEndpoint class by modifying the delete method. The new logic deletes related CycleIssue records followed by ModuleIssue records before proceeding to delete the main issues. Additionally, a declaration for ModuleIssue was added to support this functionality.

Changes

File	Changes Summary
apiserver/.../views/issue/base.py	Modified the delete method in BulkDeleteIssuesEndpoint to first delete all related CycleIssue records, then ModuleIssue records, and finally the issues themselves. Added a variable declaration for ModuleIssue.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant E as BulkDeleteIssuesEndpoint
    participant CI as CycleIssue DB
    participant MI as ModuleIssue DB
    participant I as Issue DB

    C->>E: Send bulk delete request with issue_ids
    E->>CI: Delete related CycleIssue records
    E->>MI: Delete related ModuleIssue records
    E->>I: Delete main issues

Loading

Possibly related PRs

• [WEB-2809] chore: changed the soft deletion logic #6171: Addresses similar deletion logic with a focus on soft deletion for related objects in the same file, showing a connection in handling deletions.

Suggested labels

🐛bug, ⚙️backend

Suggested reviewers

• sriramveeraghanta
• pablohashescobar

Poem

Oh, I’m a rabbit with a skip so bright,
Cleaning up issues with all my might.
Cycle and module records hop away,
Before the main issues end their day.
Happy code, like carrots in sight!
🐇🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbdf2f0 and a9751aa.

📒 Files selected for processing (1)

• apiserver/plane/app/views/issue/base.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

apiserver/plane/app/views/issue/base.py (2)

48-48: Good addition of ModuleIssue import

Adding the ModuleIssue import is necessary for the bulk deletion functionality being implemented below.

---

742-748:

Details

✅ Verification successful

Well-structured fix for bulk deletion

The implementation now properly handles the relationships when bulk deleting issues by:

1. First deleting the related CycleIssue records
2. Then deleting the related ModuleIssue records
3. Finally deleting the issues themselves

This ensures proper cleanup and prevents orphaned records in the database, directly addressing the bug mentioned in the PR description.

---

🏁 Script executed:

#!/bin/bash
# Verify if there are other issue deletion methods that should handle CycleIssue and ModuleIssue

# Check for single issue deletion (like in destroy method)
rg -n "issue.*delete" --type py | grep -v "BulkDeleteIssuesEndpoint"

# Check if the system uses cascading deletion for these relationships
rg -n "CASCADE" --type py | grep -A 5 -B 5 "ModuleIssue\|CycleIssue"

Length of output: 40951

---

Bulk deletion ordering verified and approved
The bulk deletion logic in apiserver/plane/app/views/issue/base.py correctly ensures that related CycleIssue records are deleted first, followed by related ModuleIssue records, and finally the issues themselves. Our review of the codebase confirms that no cascading deletion is used elsewhere for these relationships, so this explicit deletion order is necessary and effective in preventing orphaned records. No additional deletion methods conflict with this approach.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-3658] Cycle > work items bulk delete doesn't reflect the accurate count

Comment Automatically Generated by Plane