[WEB-3745] fix: color picker event propagation

[anmolsinghbhatia]

Description

This PR includes a fix for color picker event propagation.

Type of Change

• Bug fix

References

[WEB-3745]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced interaction handling for the color picker tool to ensure click actions are processed correctly without unexpected side effects.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-3745] Unable to select color from color pallatte for Work item type

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

The change updates the handleOnClick function within the ColorPicker component to explicitly accept a React.MouseEvent<HTMLButtonElement> parameter. Two new statements—e.stopPropagation() and e.preventDefault()—are added to the function to control event propagation and prevent default behavior. The rest of the function, including triggering the input reference click, remains unchanged.

Changes

File(s)	Summary
packages/ui/.../color-picker/color-picker.tsx	Updated the handleOnClick function signature to accept a React.MouseEvent<HTMLButtonElement> parameter. Added e.stopPropagation() and e.preventDefault() calls.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Button as ColorPicker Button
    participant Input as ColorPicker Input Reference

    User->>Button: Click event
    Button->>Button: Execute handleOnClick
    Button->>Button: e.stopPropagation()
    Button->>Button: e.preventDefault()
    Button->>Input: Trigger input click (unchanged)

Loading

Possibly related PRs

• [WEB-2537 ] fix: issue quick action #5692: Modifications to event handling functions similar to the changes applied here.
• [WEB-3540] dev: color picker component #6823: Introduces the ColorPicker component with its own handleOnClick function, showing a direct relationship with this update.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• sriramveeraghanta
• prateekshourya29

Poem

I'm a little rabbit, hopping through the code,
With changes on click, new paths are bestowed.
I stop the bubbling of events with a joyful nod,
Preventing defaults, a delightful façade.
Hop along with the code, let improvements unload!
🐰🌟 Happy coding, on this bright new road!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a57c37c and 0bf5727.

📒 Files selected for processing (1)

• packages/ui/src/color-picker/color-picker.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

packages/ui/src/color-picker/color-picker.tsx (1)

15-17: Effective fix for stopping event propagation

This change properly addresses the event propagation issue by:

1. Adding the event parameter with proper typing
2. Using stopPropagation() to prevent event bubbling
3. Using preventDefault() to cancel the default button action

This fix will prevent the click event from triggering parent element handlers when the color picker is clicked, resolving the issue described in WEB-3745.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.