[WEB-3746] fix: intake form css

[gakshita]

Description

Intake form scroll issue fixed for editor

References

[WEB-3746]

Summary by CodeRabbit

• New Features

  • Introduced a configuration option that enables a larger font size in the text editor.

• Style

  • Updated the editor’s appearance with a fixed height, refreshed border styling, and refined how overflowing content is displayed.

[coderabbitai]

Walkthrough

This pull request modifies the RichTextEditor component by updating its styling and configuration. The changes include adjusting the editor's maximum height from 50vh to 200px, altering the border color from border-custom-border-200 to border-custom-border-300, and changing the overflow behavior from overflow-y-scroll to overflow-hidden. Additionally, a new displayConfig prop with a fontSize set to "large-font" has been introduced.

Changes

File	Changes Summary
space/core/.../rich-text-editor.tsx	Updated editorClassName to change height (from 50vh to 200px), border color (from border-custom-border-200 to border-custom-border-300), and overflow (from overflow-y-scroll to overflow-hidden). Added new displayConfig prop with fontSize set to "large-font".

Possibly related PRs

• fix: editor height #5953: Modifies RichTextEditor with updates to editorClassName and introduces new properties, indicating a direct code-level relationship.
• style: remove unnecessary bottom padding from the rich text editor #5976: Alters RichTextEditor styling focusing on different aspects (height and border color) compared to previous changes, showing a related yet distinct focus.

Suggested labels

🌐frontend, 🎨UI / UX, ✍️editor

Suggested reviewers

• SatishGandham
• pushya22

Poem

I'm a rabbit, coding on the fly,
Hopping through changes, oh so spry!
Editor widened, borders redefined,
With new font size, perfectly aligned.
This code hop brings a smile—so high!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16aa1d7 and 1f70294.

📒 Files selected for processing (1)

• space/core/components/editor/rich-text-editor.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

space/core/components/editor/rich-text-editor.tsx (2)

40-40: Addition of displayConfig improves text readability.

The new displayConfig prop with fontSize: "large-font" enhances the user experience by making the text more readable within the editor. This is a good accompanying change to the styling updates.

However, since this is a new prop being added to the component, verify that this property is properly documented in the component's interface or in the underlying @plane/editor component.

---

39-39:

Details

❓ Verification inconclusive

Changes to the editor's styling address the scroll issue in the intake form.

The modification of the editorClassName changes three key aspects:

1. Fixed height: Changing from 50vh to a fixed 200px provides consistent vertical space
2. Border color: Updated from border-custom-border-200 to border-custom-border-300 for better visual distinction
3. Most importantly, changing from overflow-y-scroll to overflow-hidden removes the scroll behavior that was causing the issue

While this fixes the scrolling issue, be aware that overflow-hidden will clip content that exceeds 200px in height, potentially hiding some content from users.

Consider whether a better solution might be to use overflow-auto instead of overflow-hidden to maintain accessibility while fixing unwanted scroll behavior:

---

🏁 Script executed:

#!/bin/bash
# Check if other RichTextEditor instances use overflow-auto instead of overflow-hidden
rg "overflow-auto" --type=tsx --files-with-matches

Length of output: 78

---

Action Required: Verify Overflow Behavior Modification

The changes to the editor’s styling effectively address the scroll issue in the intake form by:

• Fixing the height: Replacing 50vh with a fixed height (max-h-[200px]) for consistent vertical space.
• Updating the border: Switching from border-custom-border-200 to border-custom-border-300 to enhance visual separation.
• Removing scroll: Changing from overflow-y-scroll to overflow-hidden to stop unwanted scrolling.

However, using overflow-hidden may clip content that exceeds 200px in height. The original review comment suggests considering overflow-auto as an alternative to preserve accessibility by allowing scrolling only when necessary.

Please note: An attempt to automatically search for other instances of overflow-auto via the script produced an error (unrecognized file type: tsx). I recommend manually verifying whether other parts of the codebase or similar components use overflow-auto to ensure consistency and to evaluate if it might be a better solution here.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-3746] Intake forms Bugs

Comment Automatically Generated by Plane