Skip to content

[WEB-3904] fix: sub work item fetching#6945

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub-work-item-fetching
Apr 17, 2025
Merged

[WEB-3904] fix: sub work item fetching#6945
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub-work-item-fetching

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Apr 17, 2025

Description

This PR includes a fix for fetching sub-work items.

Type of Change

  • Bug fix

References

[WEB-3904]

Summary by CodeRabbit

  • Refactor
    • Updated how sub-issues are fetched within the issue list item component to use a new internal approach. There is no visible change to end-user functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 17, 2025

Walkthrough

This change updates the issue-list-item.tsx component to obtain the fetchSubIssues function from the useSubIssueOperations hook, initialized with EIssueServiceType.ISSUES, instead of relying on the fetchSubIssues method from the subIssueOperations prop. The component's logic for fetching sub-issues on user interaction remains the same, but the source of the function has changed. No other logic, control flow, or exported entity declarations were modified.

Changes

File(s) Change Summary
web/core/components/issues/sub-issues/issue-list-item.tsx Switched from using subIssueOperations.fetchSubIssues prop to the fetchSubIssues from the useSubIssueOperations hook with EIssueServiceType.ISSUES. Added the hook import and updated the click handler accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant IssueListItem
    participant useSubIssueOperations
    participant IssueService

    User->>IssueListItem: Click expand sub-issues
    IssueListItem->>useSubIssueOperations: fetchSubIssues (EIssueServiceType.ISSUES)
    useSubIssueOperations->>IssueService: Fetch sub-issues
    IssueService-->>useSubIssueOperations: Return sub-issues data
    useSubIssueOperations-->>IssueListItem: Return sub-issues data
    IssueListItem-->>User: Display sub-issues
Loading

Possibly related PRs

  • [WEB-3859] fix: work item links #6930: Updates the useSubIssueOperations hook to require an explicit issueServiceType parameter, which directly relates to this PR's change to use the hook with EIssueServiceType.ISSUES.

Suggested reviewers

  • sriramveeraghanta
  • vamsikrishnamathala

Poem

A hop and a skip, a hook in the code,
Fetching sub-issues the new, proper mode.
No more old props, just a function that's neat,
With EIssueServiceType.ISSUES, the cycle's complete.
The rabbit approves, with a wiggle and cheer—
Clean hooks for the code, and the logic is clear! 🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented Apr 17, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
web/core/components/issues/sub-issues/issue-list-item.tsx (1)

66-66: Consider using the issueServiceType prop instead of hardcoding EIssueServiceType.ISSUES

The hook is initialized with a hardcoded service type, but the component accepts an issueServiceType prop (with a default value of EIssueServiceType.ISSUES). For consistency and to ensure the hook behavior matches the component's expected service type, consider using the prop value.

- const { fetchSubIssues } = useSubIssueOperations(EIssueServiceType.ISSUES);
+ const { fetchSubIssues } = useSubIssueOperations(issueServiceType);
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef56169 and d075db0.

📒 Files selected for processing (1)
  • web/core/components/issues/sub-issues/issue-list-item.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
web/core/components/issues/sub-issues/issue-list-item.tsx (1)

21-21: Good addition of the useSubIssueOperations hook import

This import allows the component to directly use the sub-issue operations from the hook instead of relying on the prop.

@sriramveeraghanta sriramveeraghanta merged commit 18fb3b8 into preview Apr 17, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-sub-work-item-fetching branch April 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants