Skip to content

[WEB-3923] fix: applied filters list#6957

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-guest-role-applied-filters
Apr 22, 2025
Merged

[WEB-3923] fix: applied filters list#6957
sriramveeraghanta merged 1 commit intopreviewfrom
fix-guest-role-applied-filters

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Apr 22, 2025

Description

This PR fixes a bug in the applied filters list on the Project Work Items page. Previously, users with the Guest role were unable to clear applied filters from the filter section. This update ensures that all users, including guests, can now remove filters as expected.

Type of Change

  • Bug fix

References

[WEB-3923]

Summary by CodeRabbit

  • New Features
    • Editing of applied filters is now always allowed within project filters.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

Walkthrough

A new prop, alwaysAllowEditing, has been added to the AppliedFiltersList component within the ProjectAppliedFiltersRoot React functional component. This prop is now passed unconditionally to the child component. No other changes to logic, state, or error handling are present in this update.

Changes

File(s) Change Summary
web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-root.tsx Added the alwaysAllowEditing prop to AppliedFiltersList.

Suggested reviewers

  • sriramveeraghanta
  • prateekshourya29

Poem

A filter here, a filter there,
Now editing’s allowed everywhere!
With a single prop, the change is neat,
The code hops forward on nimble feet.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8be836 and 193cb2f.

📒 Files selected for processing (1)
  • web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-root.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-root.tsx (1)

84-84: Great fix that improves accessibility for Guest users!

Adding the alwaysAllowEditing prop effectively addresses the issue where Guest users couldn't clear applied filters. This change makes sense from a UX perspective, as filtering is a view-only operation that should be available to all users who have access to see the content, regardless of their edit permissions.

The implementation is clean and focused, only changing what's necessary to fix the specific problem without introducing any side effects.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented Apr 22, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@sriramveeraghanta sriramveeraghanta merged commit 5dacba7 into preview Apr 22, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-guest-role-applied-filters branch April 22, 2025 12:28
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants