Skip to content

[WEB-4080]fix: set sub work items groups to expand by default#7053

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub_issue_filters
May 13, 2025
Merged

[WEB-4080]fix: set sub work items groups to expand by default#7053
sriramveeraghanta merged 1 commit intopreviewfrom
fix-sub_issue_filters

Conversation

@vamsikrishnamathala
Copy link
Member

@vamsikrishnamathala vamsikrishnamathala commented May 13, 2025

Description

This update sets the groups in sub-work items to expand by default.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

WEB-4080

Summary by CodeRabbit

  • New Features

    • Added a loading indicator with placeholders when sub-issues are initializing.
  • Refactor

    • Sub-issue groups now always start expanded by default, regardless of group type.

@vamsikrishnamathala vamsikrishnamathala self-assigned this May 13, 2025
@vamsikrishnamathala vamsikrishnamathala added the 🐛bug Something isn't working label May 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 13, 2025

Error: Could not generate a valid Mermaid diagram after multiple attempts.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75d81f9 and c26f053.

📒 Files selected for processing (2)
  • web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-group.tsx (1 hunks)
  • web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (4)
web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-group.tsx (1)

48-48: Set sub-issue accordion groups to expand by default

This change ensures that all sub-issue groups will be expanded by default (rather than only the "all issues" group), improving discoverability and reducing the number of clicks needed to view sub-issues.

web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx (3)

8-8: Added Loader import for loading state handling

Good addition to support the loading state implementation.


47-47: Added destructuring of loader property

Properly extracting the loader state from the subIssues store.


80-88: Added loading state with skeleton UI

Good addition of a loading state that shows placeholder items during the initial loading phase. This improves the user experience by providing visual feedback while waiting for the sub-issues to load.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented May 13, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@vamsikrishnamathala vamsikrishnamathala changed the title [WEB-4080]fix: set accordion to expand by default [WEB-4080]fix: sub sub work items groups to expand by default May 13, 2025
@vamsikrishnamathala vamsikrishnamathala changed the title [WEB-4080]fix: sub sub work items groups to expand by default [WEB-4080]fix: set sub work items groups to expand by default May 13, 2025
@sriramveeraghanta sriramveeraghanta merged commit 3a6d0c1 into preview May 13, 2025
4 of 5 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-sub_issue_filters branch May 13, 2025 10:48
al-jaber-nishad pushed a commit to Xinotrix-Home/task-and-meeting-management that referenced this pull request May 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jul 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants