Skip to content

[WEB-4118]fix: adjusted sub work item properties for a better visibility#7079

Merged
sriramveeraghanta merged 2 commits intopreviewfrom
fix-sub_work_item_prpperties
May 23, 2025
Merged

[WEB-4118]fix: adjusted sub work item properties for a better visibility#7079
sriramveeraghanta merged 2 commits intopreviewfrom
fix-sub_work_item_prpperties

Conversation

@vamsikrishnamathala
Copy link
Member

@vamsikrishnamathala vamsikrishnamathala commented May 19, 2025

Description

Updated the size and view for State icon in sub work item list view.
Removed start date from the list view.
Removed Projects filter for sub-work items.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

WEB-4120

Summary by CodeRabbit

  • New Features

    • Added support for customizable icon sizes in state dropdown menus, allowing for more flexible visual presentation.
  • Style

    • Updated the appearance of the state dropdown in sub-issue properties, including larger icons and a new button style.
    • Enhanced tooltips for both state and priority dropdowns for improved usability.
  • Refactor

    • Removed the start date editing option from sub-issue properties, simplifying the interface.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 19, 2025

Walkthrough

The changes introduce an optional iconSize prop to the StateDropdown component, allowing dynamic control of icon sizing. This prop is utilized in the dropdown's rendering. In the sub-issues list item properties, the StateDropdown and PriorityDropdown components receive updated props, and the UI for editing the start_date property is removed. Additionally, the "project" filter is removed from the sub work items list filters constant.

Changes

File(s) Change Summary
web/core/components/dropdowns/state.tsx Added optional iconSize prop to StateDropdown and used it to control icon size in the component. Updated the component signature and default value for iconSize.
web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/properties.tsx Updated StateDropdown and PriorityDropdown props in the SubIssuesListItemProperties component. Changed button variant, icon size, and enabled tooltips. Removed the start_date property editing UI and related logic.
packages/constants/src/issue/filter.ts Removed the "project" filter from the filters array in the sub_work_items.list configuration within the ISSUE_DISPLAY_FILTERS_BY_PAGE constant.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SubIssuesListItemProperties
    participant StateDropdown
    participant PriorityDropdown

    User->>SubIssuesListItemProperties: Render sub-issue properties
    SubIssuesListItemProperties->>StateDropdown: Render with iconSize="size-5", showTooltip, button props
    SubIssuesListItemProperties->>PriorityDropdown: Render with showTooltip
Loading

Poem

A dropdown’s icon, now big or small,
With iconSize you can change them all!
Tooltips appear with a gentle glow,
While start dates quietly go.
Rabbits cheer for options neat—
Custom icons make the UI sweet! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between d51c198 and 0e02c0d.

📒 Files selected for processing (1)
  • packages/constants/src/issue/filter.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
packages/constants/src/issue/filter.ts (1)

358-358: Project filter correctly removed from sub work items

The removal of the "project" filter from sub work items list makes sense as sub-issues exist within the context of a parent issue and project, making this filter redundant. This change aligns with the PR objective to improve sub work item visibility.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vamsikrishnamathala vamsikrishnamathala changed the title [WEB-41118]fix: adjusted sub work item properties for a better visibility [WEB-4118]fix: adjusted sub work item properties for a better visibility May 19, 2025
@makeplane
Copy link

makeplane bot commented May 19, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@sriramveeraghanta sriramveeraghanta merged commit 84fc81d into preview May 23, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-sub_work_item_prpperties branch May 23, 2025 10:44
al-jaber-nishad pushed a commit to Xinotrix-Home/task-and-meeting-management that referenced this pull request May 27, 2025
…ity (makeplane#7079)

* fix: adjusted sub work item properties for a better visibility

* fix: removed projects from sub work item filters
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
…ity (#7079)

* fix: adjusted sub work item properties for a better visibility

* fix: removed projects from sub work item filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants