Skip to content

[WEB-2403] fix: alignment of project states in collapsed view#7114

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-project-states-alignment
May 26, 2025
Merged

[WEB-2403] fix: alignment of project states in collapsed view#7114
sriramveeraghanta merged 1 commit intopreviewfrom
fix-project-states-alignment

Conversation

@JayashTripathy
Copy link
Member

@JayashTripathy JayashTripathy commented May 23, 2025

Description

Alignment of project states in collapsed view

Before
Screenshot 2025-05-23 at 5 26 37 PM

After
Screenshot 2025-05-23 at 5 27 27 PM

Type of Change

  • Improvement (change that would cause existing functionality to not work as expected)

Summary by CodeRabbit

  • Style
    • Improved layout by removing extra bottom margin from the sticky header in the Kanban view.
    • Adjusted icon container size in header cards for better alignment and visual consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 23, 2025

Walkthrough

The changes adjust the styling of Kanban board header components. Specifically, a bottom margin is removed from the sticky header wrapper, and the icon container within the header card receives increased height and a fixed width. No logic, control flow, or public API is affected.

Changes

File(s) Change Summary
web/core/components/issues/issue-layouts/kanban/default.tsx Removed bottom margin (mb-1) from the sticky header div wrapping the HeaderGroupByCard component.
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx Increased icon container height from 20px to 25px and set width to 20px in the header card component.

Suggested labels

🐛bug, 🌐frontend

Poem

A hop, a skip, a margin gone—
The Kanban board keeps moving on.
Icons stretch a little tall,
With headers neat against the wall.
Rabbits cheer this tidy feat,
Where code and carrots always meet! 🥕

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented May 23, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (1)

120-122: Nitpick: Extract icon size to shared theme variables.

Consider defining these hard-coded Tailwind dimensions (h-[25px], w-[20px]) as design tokens or in your Tailwind config under theme.extend so that future visual tweaks remain consistent and centralized.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84fc81d and 595f9a7.

📒 Files selected for processing (2)
  • web/core/components/issues/issue-layouts/kanban/default.tsx (1 hunks)
  • web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
web/core/components/issues/issue-layouts/kanban/headers/group-by-card.tsx (1)

120-122: Approve: Icon container dimensions updated for improved vertical alignment.

Increasing the container height to h-[25px] and adding a fixed width of w-[20px] ensures the icon (or fallback Circle) is centered consistently, resolving the misalignment in collapsed view.

web/core/components/issues/issue-layouts/kanban/default.tsx (1)

164-166: Approve: Removed bottom margin from sticky header for tighter spacing.

Dropping the mb-1 class from the sticky header div tidies up extra vertical space, aligning the header rows precisely in the collapsed state without impacting any logic.

@JayashTripathy JayashTripathy added 🌟enhancement New feature or request 🌐frontend 🌟improvement and removed 🌟enhancement New feature or request labels May 23, 2025
@sriramveeraghanta sriramveeraghanta merged commit 5a208cb into preview May 26, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-project-states-alignment branch May 26, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants