[WEB-4182] Fix work item links error messages

[JayashTripathy]

Description

• fixed the position of X in the toast for small screens
  Before

After

• fixed error toast while creating or updating the link

Before

After

Type of Change

• Improvement (change that would cause existing functionality to not work as expected)

Summary by CodeRabbit

• Style

  • Adjusted the close (X) icon in toast notifications to use absolute positioning, improving its placement within the toast.

• Bug Fixes

  • Updated error message handling for link operations to display more accurate feedback in toast notifications.
  • Improved error handling for link updates, ensuring errors are properly propagated to the user interface.

[coderabbitai]

Walkthrough

This update modifies the error handling in link-related components and store logic, ensuring errors are now propagated instead of silently handled. Additionally, it adjusts the CSS positioning of the close icon in the toast component from fixed to absolute, affecting its placement within the toast container.

Changes

File(s)	Change Summary
packages/ui/src/toast/index.tsx	Changed close icon's CSS from fixed to absolute positioning within the toast component.
web/core/components/issues/issue-detail-widgets/links/helper.tsx	Updated error message extraction in toast notifications for create/update methods.
web/core/store/issue/issue-details/link.store.ts	Modified updateLink to rethrow errors instead of returning initial data on failure.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant LinkStore

    User->>UI: Initiates link update
    UI->>LinkStore: updateLink()
    LinkStore->>LinkStore: Try to update link
    alt Success
        LinkStore-->>UI: Return updated link
    else Error
        LinkStore-->>UI: Throw error
        UI->>UI: Show error toast with error.data.error
    end

Loading

Possibly related PRs

• [WEB-3859] fix: work item links #6930: Updates hook signatures and error handling in link-related components, similar to changes in this PR.
• [WEB-3863] fix: handled error handling for link editing #6968: Modifies error handling and rollback logic in the updateLink method, directly related to this PR's changes.

Suggested labels

🌐frontend, 🧹chore

Suggested reviewers

• sriramveeraghanta
• gakshita

Poem

A toast pops up, its X now floats,
No longer fixed, but close to notes.
Errors now leap, not quietly fade,
So bugs and troubles can’t evade.
With careful tweaks both big and small,
This bunny cheers the changes all! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04c7c53 and 3822b1b.

📒 Files selected for processing (3)

• packages/ui/src/toast/index.tsx (1 hunks)
• web/core/components/issues/issue-detail-widgets/links/helper.tsx (2 hunks)
• web/core/store/issue/issue-details/link.store.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

packages/ui/src/toast/index.tsx (1)

111-111: LGTM! This fixes the toast close button positioning issue on small screens.

Changing from fixed to absolute positioning ensures the close button stays within the toast container boundaries, as it's now positioned relative to its parent container (which has relative positioning) rather than the viewport.

web/core/store/issue/issue-details/link.store.ts (1)

144-144: Good improvement to error propagation!

Throwing the error instead of returning stale data allows callers to properly handle failures. The state is correctly restored before throwing, maintaining data consistency.

web/core/components/issues/issue-detail-widgets/links/helper.tsx (1)

35-35: LGTM! Corrected error message extraction path.

The simplified error path error?.data?.error properly extracts error messages from the API response, fixing the error toast display issue mentioned in the PR objectives.

Also applies to: 53-53

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4182] Incorrect Toast Alert When Creating a Duplicate Link in Work Item

Comment Automatically Generated by Plane