[WIKI-399] fix: add favorite action to page header

[aaryan610]

Description

This PR adds the missing favorite action from page header.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• New Features
  • Added a new favorite control to the page header, allowing users to mark pages as favorites directly from the header actions.

[coderabbitai]

Walkthrough

A new UI control, PageFavoriteControl, has been added to the page header actions. The component is imported and rendered alongside existing controls without altering any other logic or properties.

Changes

File	Change Summary
web/core/components/pages/header/actions.tsx	Added import and rendering of PageFavoriteControl in the header actions UI.

Poem

A favorite star now shines so bright,
In header actions, pure delight.
Beside the link and options found,
A new control now comes around.
The page can sparkle, marked with glee—
A favorite for you and me!
⭐

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 322af8c and 38e3c88.

📒 Files selected for processing (1)

• web/core/components/pages/header/actions.tsx (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

web/core/components/pages/header/actions.tsx (1)

web/core/components/pages/header/favorite-control.tsx (1)

• PageFavoriteControl (13-31)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

web/core/components/pages/header/actions.tsx (2)

16-16: LGTM! Import follows established patterns.

The import statement is clean and follows the existing local import patterns in the file.

---

35-35:

Details

❓ Verification inconclusive

Good addition! Verify UX placement and functionality.

The component integration looks correct with proper prop passing. The PageFavoriteControl component appears well-implemented based on the code snippet, with appropriate permission checks and styling.

Consider verifying:

• The favorite action placement provides good UX flow in the header
• The toggle functionality works as expected with the existing page operations

---

🏁 Script executed:

#!/bin/bash
# Description: Verify that PageFavoriteControl integrates properly with the existing codebase

# Check if there are any other usages of PageFavoriteControl to ensure consistency
rg -A 3 -B 3 "PageFavoriteControl" --type tsx --type ts

# Check if the page prop structure matches what the component expects
ast-grep --pattern 'interface $_Props {
  $$$
  page: $T;
  $$$
}'

# Verify the component's dependencies and ensure no circular imports
rg -A 5 "import.*PageFavoriteControl" --type tsx --type ts

Length of output: 241

---

🏁 Script executed:

#!/bin/bash
set -e

# Find all occurrences of PageFavoriteControl across the codebase
rg -n 'PageFavoriteControl'

# Check import statements for PageFavoriteControl
rg -n "import.*PageFavoriteControl"

# Find interface definitions including a `page` prop to confirm the expected shape
rg -n 'interface.*Props' -A3

Length of output: 36328

---

🏁 Script executed:

#!/bin/bash
set -e

# Show the Props interface for PageFavoriteControl
rg -n 'interface Props' web/core/components/pages/header/favorite-control.tsx -A5

# Display the top of actions.tsx to see where `page` comes from and its type
sed -n '1,100p' web/core/components/pages/header/actions.tsx

Length of output: 92

---

Verify Props interface and ensure correct page type
Please confirm that the page prop passed to <PageFavoriteControl /> matches its Props interface and that the object coming into actions.tsx is correctly typed. Also double-check for any circular imports and validate the UX placement and toggle behaviour.

• Review the Props definition in web/core/components/pages/header/favorite-control.tsx
• Confirm the origin and type of page in web/core/components/pages/header/actions.tsx
• Ensure there are no circular import paths between these files
• Validate that the favorite control’s placement and toggle functionality work smoothly in the header

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WIKI-399] Add favorite action to page header

Comment Automatically Generated by Plane