-
Notifications
You must be signed in to change notification settings - Fork 3.6k
refactor: Admin App with better layouts and Meta Information #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
81234e3
fix: layout structure in admin
sriramveeraghanta 3303e50
fix: layout structure in admin
sriramveeraghanta 37601eb
fix: delete layout files
sriramveeraghanta a7e97d8
chore: updated form related info
sriramveeraghanta ecbf4e3
sync: preview changes
sriramveeraghanta 90c49cc
fix: admin import statements
sriramveeraghanta 22ae37f
fix: general page unauthorized flickering issue
sriramveeraghanta 383cab3
chore: sync preview changes and merge conflicts
sriramveeraghanta e3142ac
chore: logs related
sriramveeraghanta bc3fa90
chore: merge conflicts
sriramveeraghanta 41e5a49
chore: lock file updates
sriramveeraghanta 0223a6a
fix: build errors
sriramveeraghanta 0a6ad75
fix: coderabbit suggestions
sriramveeraghanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
admin/app/ai/layout.tsx → admin/app/(all)/(dashboard)/ai/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
| import { AdminLayout } from "@/layouts/admin-layout"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Artificial Intelligence Settings - Plane Web", | ||
| title: "Artificial Intelligence Settings - God Mode", | ||
| }; | ||
|
|
||
| export default function AILayout({ children }: { children: ReactNode }) { | ||
| return <AdminLayout>{children}</AdminLayout>; | ||
| return <>{children}</>; | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
admin/app/(all)/(dashboard)/authentication/github/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "GitHub Authentication - God Mode", | ||
| }; | ||
|
|
||
| export default function GitHubAuthenticationLayout({ children }: { children: ReactNode }) { | ||
| return <>{children}</>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
admin/app/(all)/(dashboard)/authentication/gitlab/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "GitLab Authentication - God Mode", | ||
| }; | ||
|
|
||
| export default function GitlabAuthenticationLayout({ children }: { children: ReactNode }) { | ||
| return <>{children}</>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
admin/app/(all)/(dashboard)/authentication/google/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Google Authentication - God Mode", | ||
| }; | ||
|
|
||
| export default function GoogleAuthenticationLayout({ children }: { children: ReactNode }) { | ||
| return <>{children}</>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
admin/app/authentication/layout.tsx → ...ll)/(dashboard)/authentication/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
| import { AdminLayout } from "@/layouts/admin-layout"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Authentication Settings - Plane Web", | ||
| }; | ||
|
|
||
| export default function AuthenticationLayout({ children }: { children: ReactNode }) { | ||
| return <AdminLayout>{children}</AdminLayout>; | ||
| return <>{children}</>; | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
admin/app/email/layout.tsx → admin/app/(all)/(dashboard)/email/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,14 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
| import { AdminLayout } from "@/layouts/admin-layout"; | ||
|
|
||
| interface EmailLayoutProps { | ||
| children: ReactNode; | ||
| } | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Email Settings - Plane Web", | ||
| title: "Email Settings - God Mode", | ||
| }; | ||
|
|
||
| export default function EmailLayout({ children }: EmailLayoutProps) { | ||
| return <AdminLayout>{children}</AdminLayout>; | ||
| return <>{children}</>; | ||
| } |
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
5 changes: 2 additions & 3 deletions
5
admin/app/general/layout.tsx → .../app/(all)/(dashboard)/general/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
| import { AdminLayout } from "@/layouts/admin-layout"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "General Settings - Plane Web", | ||
| title: "General Settings - God Mode", | ||
| }; | ||
|
|
||
| export default function GeneralLayout({ children }: { children: ReactNode }) { | ||
| return <AdminLayout>{children}</AdminLayout>; | ||
| return <>{children}</>; | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
admin/app/image/layout.tsx → admin/app/(all)/(dashboard)/image/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,14 @@ | ||
| import { ReactNode } from "react"; | ||
| import { Metadata } from "next"; | ||
| import { AdminLayout } from "@/layouts/admin-layout"; | ||
|
|
||
| interface ImageLayoutProps { | ||
| children: ReactNode; | ||
| } | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Images Settings - Plane Web", | ||
| title: "Images Settings - God Mode", | ||
| }; | ||
|
|
||
| export default function ImageLayout({ children }: ImageLayoutProps) { | ||
| return <AdminLayout>{children}</AdminLayout>; | ||
| return <>{children}</>; | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.