[WEB-4363] regression: analytics tabs improvements

[aaryan610]

Description

This PR fixes some minor bugs in the analytics tabs page-

1. Added missing param type.
2. Updated disabled state key.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Bug Fixes

  • Corrected tab configuration to ensure tabs are properly enabled or disabled as expected.

• Refactor

  • Improved type usage and removed unused imports for better maintainability.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4363] Improvement Work Item: Analytics Tab Improvement

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

The changes update the analytics page component by removing an unused import, explicitly typing the tabs array, updating the Props interface to include workspaceSlug, and renaming a property in the tab configuration for consistency with the expected component API.

Changes

File(s)	Change Summary
web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx	Removed unused useSearchParams import, explicitly typed tabs as TabItem[], added workspaceSlug to Props, and renamed isDisabled to disabled in tab config.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AnalyticsPage
    participant TabsComponent

    User->>AnalyticsPage: Navigates to analytics page
    AnalyticsPage->>TabsComponent: Passes typed tabs array with 'disabled' property
    TabsComponent-->>AnalyticsPage: Renders tabs according to configuration
    AnalyticsPage-->>User: Displays analytics interface

Loading

Possibly related PRs

• [WEB-4339] fix: projects dropdown shows all projects #7238: Removes useSearchParams from another analytics component, indicating a coordinated update in URL parameter handling.
• [WEB-4363]: Analytics tab improvements #7248: Modifies analytics tab functionality in the same file, including prop typing and tab configuration changes.

Suggested labels

ready_to_merge

Suggested reviewers

• vamsikrishnamathala
• sriramveeraghanta

Poem

A hop and a skip through tabs anew,
With types more clear and imports few,
The slug now joins the Props parade,
And "disabled" gets its accolade.
Analytics shines, all neat and bright—
This rabbit’s code feels just right! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79c2dfd and 62ae5ec.

📒 Files selected for processing (1)

• web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript)

🔇 Additional comments (5)

web/app/(all)/[workspaceSlug]/(projects)/analytics/[tabId]/page.tsx (5)

5-5: LGTM! Good cleanup of unused import.

Removing the unused useSearchParams import improves code cleanliness and reduces unnecessary dependencies.

---

9-9: LGTM! Excellent type safety improvement.

Explicitly importing and using the TabItem type from @plane/ui provides better type safety and IDE support for the tabs configuration.

---

22-22: LGTM! Props interface correctly updated.

Adding workspaceSlug: string to the params type correctly reflects the route structure and ensures proper typing for the component parameters.

---

58-58: LGTM! Proper typing of tabs array.

Explicitly typing the tabs array as TabItem[] ensures type safety and provides better IDE support for the tab configuration objects.

---

67-67: LGTM! Fixed property name for Tabs component API.

Changing isDisabled to disabled aligns with the expected prop name for the Tabs component from @plane/ui, fixing the disabled state functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.