Skip to content

[WEB-4387] fix: global layout when filter is set to list#7264

Merged
pushya22 merged 1 commit intopreviewfrom
fix-global-layout
Jun 24, 2025
Merged

[WEB-4387] fix: global layout when filter is set to list#7264
pushya22 merged 1 commit intopreviewfrom
fix-global-layout

Conversation

@prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Jun 24, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Refactor
    • Updated the layout selection for issues to always use the spreadsheet view, removing dynamic layout changes based on filters.

@makeplane
Copy link

makeplane bot commented Jun 24, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 24, 2025

Walkthrough

The change simplifies the logic in the AllIssueLayoutRoot component by removing dynamic extraction and computation of layout types based on filters. The activeLayout is now hardcoded to a specific layout type, eliminating dependencies on the filter state and related computations.

Changes

File(s) Change Summary
web/core/components/issues/issue-layouts/roots/all-issue-layout-root.tsx Removed dynamic extraction of filters and computation of layout; statically set activeLayout.

Suggested labels

🐛bug, 🌐frontend, ready to merge

Suggested reviewers

  • sriramveeraghanta
  • vamsikrishnamathala

Poem

A layout once danced to a filter’s tune,
Now stands still, like a spreadsheet moon.
No more guessing which view to display—
The code is simpler, come what may!
As rabbits hop with glee and cheer,
Static layouts bring changes near.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 072f2e2 and 8cc4496.

📒 Files selected for processing (1)
  • web/core/components/issues/issue-layouts/roots/all-issue-layout-root.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
web/core/components/issues/issue-layouts/roots/all-issue-layout-root.tsx (2)

35-35: LGTM: Simplified destructuring aligns with the hardcoded layout approach.

The removal of filters from the destructuring is consistent with the change to hardcode the layout, eliminating the need for dynamic filter-based layout determination.


45-45: ```shell
#!/bin/bash

Search for any usage of activeLayout in TS/TSX files

rg "activeLayout" -g ".ts" -g ".tsx" -C5

Find all references to EIssueLayoutTypes.SPREADSHEET to see where it’s used

rg "EIssueLayoutTypes.SPREADSHEET" -g ".ts" -g ".tsx" -C3

Check for any instances where AllIssueLayoutRoot is imported or used

rg "AllIssueLayoutRoot" -g ".ts" -g ".tsx" -C5


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAbQB1AFEAITAAFgBmAA4AdgBdSAAzeAAPLiIvQTRfLzRZfDxIAHdYMiL4Lxo+VEQSUIJIAAMvJFxB6Oa0ZAcBZnUaejkw1shsXr5eahISAGtEWAaXNAAmAE50DHpUeCUMcWKoqes7DEcBSkgc44A2NI0YFYMWCYUjINC0Wj+RBgyACbBEdolPwkWoLML4ZYeCpVGp1Bqhd7AiTwfB8FptXArYqdD49ProzFDEaIMb8bjifAYf7uSBKRAMCjwdkkrC9MQilCXeAMLbISnURm2HgUfDEvnoXl9bSRejFJGFUnLa7Q4IAGkYWyIpPgAC8oiQStwRgx1F55E80JAMJywAJ/GgdvAMAi4Qi9f8AHIY8G0dQi6qa3DasECfGM+DMJ0kNh3agSw2IbiieDFBiMYHB6TofzK1U3KJBxl8gVCjlcgEeJUyrDvZHEkhNR79FYAVRsABkuLBcLhuIgOAB6BdEdSwbACDRMZgL5gBkhOzAkBcH8jH7xeBdfX4aIz6YzgKBkej4Qo4AjEMjKNFbnOcZX8YRRHEKQZHkJglCoVR1C0HQ7xMKA4GNC430IUhyCob8WF/LgqCaexHF3FxYTAxRlCgzRtF0MBDHvUwDEHAQFyYfwmJYbhOXYRAFyQBxpG4k0SDAWp6jwLiVXwXAuOqLwwB44IhLxPAwHEzRJLKAxok0gwLEgABBABJD90K2egHCcIiX3LEFpDcQEK1BZFmFVDxKQ8B1cCocVOX4V9BmpLpEEGIoVWYRlBjk6QADEOi6IKWVJDwDnwHYLnoFEMyDLYm0oSQ828yzwoE6KaQoQLUqGNBxSkcdFNZAQpiibzXMYbAKH8O4hmxeqvAANXgAd9NoILMCuST0GhfAXRM9oSsQf59IwFkSHBc1msGSrgJIGqRNZVBvTwlk8xlHx5F6foMUGRJ9IE7b8WgWQizmgBlWxEl0gARJ6AAlEkSaBBm5BBkH8JyQN5WQMDQOYy2EtMlC6OZIbbWEGufUUCH8XUYsoMFLkgYEKFocCq2a2HGlwB6SEBjwoVCSzSfwFcyxGhQ7hVXxCkqPCQe0LBsAwIFrNoG8jG0yxdJKvLFoZZqlAYWoMJFZBLIddiKDRQ1uHXZ1IHYOMbIMKAoysys5QxWXRAVqXlb4RB4CIJHWqrFXHVJDWNm16VdbufXkEbQYJa8a7eNuvAbHwCSgq3djyDuG9NOiW9qNox88cstA8FQz8MKiH92BwtADoI5x5CWYnILUCjYOT+CFFYdQAH0bkQBv/H7QdaAbw71aomja6yBgGDSNJTm+AAGNAR4AVhyCEZ6n05aEKEhjgARjSNAcgEVeV+OKfaFX74cgYVeyzvAxa5/Rvm9bkh27oBun17oA -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=makeplane/plane&utm_content=7264):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@pushya22 pushya22 merged commit 40c0922 into preview Jun 24, 2025
5 of 6 checks passed
@pushya22 pushya22 deleted the fix-global-layout branch June 24, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants