[WIKI-508] fix: select all with table select

[Palanikannan1437]

Description

Table selection works with CMD/CTRL+A

Summary by CodeRabbit

• New Features

  • Improved "Select All" keyboard shortcut to enable a two-step selection: first selects within node boundaries, then selects the entire document on a second press.

• Bug Fixes

  • Ensured consistent behavior for the "Select All" shortcut regardless of the initial selection state.

[coderabbitai]

Walkthrough

The keyboard shortcut handler for "Mod-a" in the editor was updated to implement a two-step selection process. The first press selects the current node's content if not already fully selected; a subsequent press selects the entire document. The handler now always returns true after handling either case.

Changes

File(s)	Change Summary
packages/editor/src/core/extensions/keymap.ts	Modified "Mod-a" shortcut logic to implement two-step selection: node content first, then document.

Poem

A tap selects a word, a second, the whole,
My shortcut now plays a more thoughtful role.
From node to document, selection grows wide,
With every press, the bounds open wide.
Hooray for the keys, and the code they control!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6923f and 0d21c2d.

📒 Files selected for processing (1)

• packages/editor/src/core/extensions/keymap.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/editor/src/core/extensions/keymap.ts (2)

111-129: Excellent implementation of progressive selection behavior!

The two-step selection logic is well-implemented and follows common editor UX patterns. The first press selects content within node boundaries (perfect for table cells), and the second press selects the entire document.

Key strengths:

• Clear logic flow with appropriate comments
• Consistent return values (both branches return true)
• Proper use of existing commands (selectTextWithinNodeBoundaries and selectAll)
• Addresses the PR objective of fixing table selection behavior

---

125-128: Add tests for nested selection scenarios
We ran searches and found no existing tests or usage examples validating selectAll() behavior with tables or other complex nested structures. To ensure editor.commands.selectAll() handles edge cases—such as tables within tables, lists inside tables, blockquotes containing tables, etc.—please add dedicated test coverage.

Suggested actions:

• Create tests in your editor-commands or extensions test suite (e.g., packages/editor/tests/commands/select-all.spec.ts).
• Add scenarios covering:
  • A document with nested tables
  • Tables inside lists and lists inside tables
  • Tables within blockquotes or other container nodes
• Verify that selectAll() selects the entire document in each scenario without errors.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WIKI-508] Fix editor select all logic with Table as the first node

Comment Automatically Generated by Plane